feat: Update to .NET 8, refresh NuGet packages, and add GitHub workflows #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've updated your solution to .NET 8 LTS.
All NuGet packages have been updated to their latest stable versions.
I've refactored the `TBUtil.MessagingSqs.MessageQueue` class to support dependency injection for `IAmazonSQS` and `IAmazonSimpleNotificationService`, improving testability.
I've also added two GitHub Actions workflows:
1. `.github/workflows/dotnet-test.yml`: This will trigger when you push or create a pull request to the `main` branch. It builds the solution and runs unit tests.
2. `.github/workflows/dotnet-publish.yml`: This will trigger on tags matching `v*.*.*`. It builds, packs, and publishes the `TBUtil.MessagingSqs` NuGet package to nuget.org.
**Action Required:** You'll need to configure a `NUGET_API_KEY` secret in your GitHub repository settings for publishing to work.
**Known Issue:**
The unit tests in `MessagingSqs.Tests/TBUtil.MessagingSqs.Tests.csproj` are currently NOT compiling or passing. I attempted to refactor them to use Moq with the updated AWS SDK v3 for .NET 8, but I was unsuccessful due to the complexity of changes required in `MessageQueueTests.cs`. These tests will need your manual review and correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated your solution to .NET 8 LTS.
All NuGet packages have been updated to their latest stable versions. I've refactored the
TBUtil.MessagingSqs.MessageQueueclass to support dependency injection forIAmazonSQSandIAmazonSimpleNotificationService, improving testability.I've also added two GitHub Actions workflows:
.github/workflows/dotnet-test.yml: This will trigger when you push or create a pull request to themainbranch. It builds the solution and runs unit tests..github/workflows/dotnet-publish.yml: This will trigger on tags matchingv*.*.*. It builds, packs, and publishes theTBUtil.MessagingSqsNuGet package to nuget.org. Action Required: You'll need to configure aNUGET_API_KEYsecret in your GitHub repository settings for publishing to work.Known Issue:
The unit tests in
MessagingSqs.Tests/TBUtil.MessagingSqs.Tests.csprojare currently NOT compiling or passing. I attempted to refactor them to use Moq with the updated AWS SDK v3 for .NET 8, but I was unsuccessful due to the complexity of changes required inMessageQueueTests.cs. These tests will need your manual review and correction.