Skip to content

[ACL-291] Add support for sub_merchant objects in Payments and Payouts#246

Closed
federico1525 wants to merge 3 commits intomainfrom
feature/acl-291-sub-merchant-support
Closed

[ACL-291] Add support for sub_merchant objects in Payments and Payouts#246
federico1525 wants to merge 3 commits intomainfrom
feature/acl-291-sub-merchant-support

Conversation

@federico1525
Copy link
Contributor

@federico1525 federico1525 commented Jun 12, 2025

Summary

  • Implement sub_merchant objects for both Payments and Payouts according to OpenAPI v3 specifications
  • Add support for UltimateCounterparty with business_client and business_division types for Payments
  • Add support for UltimateCounterparty with business_client type only for Payouts
  • Update request/response models to include SubMerchants properties

Test plan

  • Build succeeds without errors
  • Unit tests pass (193/193)
  • Integration tests with sub_merchant data
  • Verify JSON serialization matches OpenAPI specs
  • Test both business_client and business_division types for Payments
  • Test business_client type for Payouts

🤖 Generated with Claude Code

federico1525 and others added 3 commits June 12, 2025 16:53
- Add UltimateCounterparty base classes with business_client and business_division types
- Add PaymentSubMerchants model supporting both counterparty types with required ultimate_counterparty
- Add PayoutSubMerchants model supporting only business_client type with optional ultimate_counterparty
- Add SubMerchants property to CreatePaymentRequest, GetPaymentResponse.PaymentDetails, and CreatePayoutRequest
- Update .gitignore to exclude Claude Code configuration files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Add PaymentSubMerchants property to GetPayoutsResponse.PayoutDetails
- Add sub_merchant test cases for Payments with business_client and business_division types
- Add sub_merchant test cases for Payouts with business_client type
- Update RequestBuilders with helper methods for creating test sub_merchant objects
- Verify sub_merchant data serialization and API integration in acceptance tests
- Add JsonPropertyName attributes with snake_case property names
- Fix ultimate_counterparty, commercial_name, registration_number, mcc, address, id, name, type properties
- Fix sub_merchants property name in requests and responses
- Ensure proper API compliance with OpenAPI v3 specifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants