Skip to content

Comments

Generator for Rack CORS#27

Open
mausamp wants to merge 21 commits intomainfrom
generator-for-rack-cors
Open

Generator for Rack CORS#27
mausamp wants to merge 21 commits intomainfrom
generator-for-rack-cors

Conversation

@mausamp
Copy link
Collaborator

@mausamp mausamp commented May 9, 2024

No description provided.

source_root File.expand_path("templates", __dir__)

class_option :origins, type: :string, default: '*',
desc: 'Specify which origins are allowed to make CORS requests'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask user to add multiple origins with space separated value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ should accept an array

private

def show_alert_message
say "❗️❗️\nPlease restart your rails server for the changes to take effect.\n", :yellow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to Readme as Abhay suggests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants