feat: add confirmation step to fund and ship invoice actions - #718
Open
luciusverus-cyber wants to merge 5 commits into
Open
feat: add confirmation step to fund and ship invoice actions#718luciusverus-cyber wants to merge 5 commits into
luciusverus-cyber wants to merge 5 commits into
Conversation
|
@luciusverus-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@luciusverus-cyber is attempting to deploy a commit to the K1NGD4VID Team on Vercel. A member of the Team first needs to authorize it. |
Closes TrusTrove#647 Closes TrusTrove#645 Closes TrusTrove#644 Closes TrusTrove#643
…ropagation, offline detection Wraps fundInvoice/shipInvoice with requestConfirmation (TrusTrove#647), re-validates invoice status before confirmDelivery submit (TrusTrove#645), propagates useProfile verification errors to react-query (TrusTrove#644), and distinguishes offline network failures from 404 in useBalances (TrusTrove#643). Closes TrusTrove#647 Closes TrusTrove#645 Closes TrusTrove#644 Closes TrusTrove#643
…rrors, offline detection Adds requestFundConfirmation and requestShipConfirmation with typing confirmation for irreversible actions (TrusTrove#647). Implements revalidateBeforeConfirm with StaleDataError for TOCTOU protection (TrusTrove#645). Propagates VerificationCheckError for useProfile registry failures instead of swallowing to false (TrusTrove#644). Adds classifyBalanceError distinguishing offline from 404 in useBalances (TrusTrove#643). Closes TrusTrove#647 Closes TrusTrove#645 Closes TrusTrove#644 Closes TrusTrove#643
|
MergeKeeper review unavailable AI provider review response did not contain valid JSON No approval or merge action was taken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wraps the
fundInvoiceandshipInvoiceactions inInvoiceCard.tsxwith the samerequestConfirmationreview step already used byconfirmDelivery/repayInvoice/defaultInvoice, closing the accidental-irreversible-action gap for these two entry points. ExtendsInvoiceCard.test.tsxto cover the confirmation step for both new actions.Closes #647
Closes #645
Closes #644
Closes #643