chore(pool): MIN_INITIAL_DEPOSIT constant lives in lib.rs instead of constants.rs

[K1NGD4VID]

Summary

contracts/pool/src/constants.rs exists specifically to hold shared numeric constants (currently just the re-exported TTL_THRESHOLD/TTL_EXTEND_TO), but MIN_INITIAL_DEPOSIT — a pool-specific economic constant used to gate the first deposit (contracts/pool/src/lib.rs lines 18-21, 170) — is defined directly in lib.rs instead.

Current Behavior

// lib.rs
pub const MIN_INITIAL_DEPOSIT: u128 = 10_000_000;

lives alongside contract logic rather than in constants.rs, which is pub use constants::*;-re-exported from lib.rs and is where a reader would expect to find contract-wide tunable numeric constants.

Expected Behavior

MIN_INITIAL_DEPOSIT (and, per the related magic-number finding, a DEFAULT_MAX_UTILIZATION_BPS) should live in constants.rs alongside the TTL constants, keeping all tunable numeric parameters in one file.

Acceptance Criteria

• Move MIN_INITIAL_DEPOSIT into constants.rs.
• Update lib.rs to reference it via the existing pub use constants::*; re-export.
• All existing tests referencing crate::MIN_INITIAL_DEPOSIT continue to compile/pass unchanged.

Tech Stack

Rust / Soroban SDK, contracts/pool/src/lib.rs, contracts/pool/src/constants.rs.

[johnmic0132]

@johnmic0132 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello, I’ve throughly reviewed the requirements and can work on fixing the issue while ensuring implementation meets the acceptance criteria

ℹ️ Repo Maintainers: To accept this application, review their application or assign @johnmic0132 to this issue.

[efuncode]

@efuncode has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I’d like to contribute by working on this issue. I’ll investigate the problem, make the appropriate changes, and run the relevant tests before opening a PR.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @efuncode to this issue.

[drips-wave]

Congratulations, @efuncode! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @efuncode: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊