Skip to content

chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (closes #592) - #711

Open
ZacLou wants to merge 1 commit into
TrusTrove:mainfrom
ZacLou:fix/move-min-initial-deposit-592
Open

chore(pool): move MIN_INITIAL_DEPOSIT to constants.rs (closes #592)#711
ZacLou wants to merge 1 commit into
TrusTrove:mainfrom
ZacLou:fix/move-min-initial-deposit-592

Conversation

@ZacLou

@ZacLou ZacLou commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Moves MIN_INITIAL_DEPOSIT from pool/src/lib.rs to pool/src/constants.rs where other shared pool constants already live. Re-exported via pub use constants::* so all call sites remain unchanged.

Diff: 2 files, +5/-5 lines. No behavioral change.

Closes #592 (replaces #710 which had a rebase error).

Moves the constant from pool/src/lib.rs to pool/src/constants.rs where
other shared pool constants already live. Re-exported via pub use
constants::* so all call sites remain unchanged.

Closes TrusTrove#592
@ZacLou
ZacLou requested a review from K1NGD4VID as a code owner September 5, 2026 16:05
@mergekeeper

mergekeeper Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

MergeKeeper review

Scope: in scope for linked issue #592.
Verdict: clean

This PR successfully moves the MIN_INITIAL_DEPOSIT constant from contracts/pool/src/lib.rs into contracts/pool/src/constants.rs as requested by the issue, utilizing the existing wildcard re-export to keep all references valid.

Reviewed commit: 8186d76a9d171585404257b52c4e7f74ffd187f6.
CI and merge eligibility are checked separately.

@mergekeeper mergekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

This PR successfully moves the MIN_INITIAL_DEPOSIT constant from contracts/pool/src/lib.rs into contracts/pool/src/constants.rs as requested by the issue, utilizing the existing wildcard re-export to keep all references valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(pool): MIN_INITIAL_DEPOSIT constant lives in lib.rs instead of constants.rs

1 participant