Updated client config controller to reference updated script name #1330

mike182uk · 2025-09-25T14:01:54Z

ref https://linear.app/ghost/issue/PROD-2455
ref TryGhost/Ghost#24985

The admin-x-activitypub script has been renamed to just activitypub so the client config endpoint should be updated to reflect this change

coderabbitai · 2025-09-25T14:02:03Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated the backend-driven frontend client identifier from admin-x-activitypub to activitypub, including emitted JSON fields and CDN URL https://cdn.jsdelivr.net/ghost/activitypub@1/dist/activitypub.js. Adjusted ADR and controller constant accordingly. GitHub Actions PR deploy workflow was modified to use GCP_PROJECT for service names, derive PR_SERVICE/DEFAULT_SERVICE from it, compute NEXT_PRIORITY = MIN_PRIORITY - 1, replace pathMatchers[0].routeRules instead of appending, make route rule expressions use dynamic env values, and print/import the generated config.yml. No control-flow or error-handling logic was changed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and concisely summarizes the main change by specifying that the client configuration controller now references the renamed script, providing enough context for reviewers without unnecessary detail.
Description Check	✅ Passed	The description directly explains that the script was renamed from admin-x-activitypub to activitypub and that the client config endpoint was updated accordingly, matching the changeset without off-topic content.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ref https://linear.app/ghost/issue/PROD-2455 ref TryGhost/Ghost#24985 The `admin-x-activitypub` script has been renamed to just `activitypub` so the client config endpoint should be updated to reflect this change

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9195985 and a57802f.

📒 Files selected for processing (1)

.github/workflows/deploy-pr.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build / Build Docker Images (linux/amd64, amd64)

coderabbitai · 2025-10-13T12:47:46Z

.github/workflows/deploy-pr.yml

+          export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 0' config.yml)
+          export NEXT_PRIORITY=$((MIN_PRIORITY - 1))


⚠️ Potential issue | 🔴 Critical

Guard against negative route priorities

MIN_PRIORITY falls back to 0, so the first time we run without any existing rules we compute NEXT_PRIORITY=-1. Cloud Load Balancer rejects negative priorities (valid range is 0..2147483647), so the import will fail and the workflow breaks. Please clamp the fallback and ensure we never subtract below zero.

- export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 0' config.yml) - export NEXT_PRIORITY=$((MIN_PRIORITY - 1)) + export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 1' config.yml) + if [ "$MIN_PRIORITY" -le 0 ]; then + export NEXT_PRIORITY=0 + else + export NEXT_PRIORITY=$((MIN_PRIORITY - 1)) + fi

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 0' config.yml)

export NEXT_PRIORITY=$((MIN_PRIORITY - 1))

export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 1' config.yml)

if [ "$MIN_PRIORITY" -le 0 ]; then

export NEXT_PRIORITY=0

else

export NEXT_PRIORITY=$((MIN_PRIORITY - 1))

fi

🤖 Prompt for AI Agents

In .github/workflows/deploy-pr.yml around lines 133-134, the script computes NEXT_PRIORITY as MIN_PRIORITY - 1 which can produce -1 when MIN_PRIORITY falls back to 0; Cloud Load Balancer rejects negative priorities. Change the logic so MIN_PRIORITY is treated as unsigned and clamp NEXT_PRIORITY to never go below 0 (e.g. if MIN_PRIORITY is 0 or missing, set NEXT_PRIORITY to 0; otherwise set NEXT_PRIORITY to MIN_PRIORITY - 1).

coderabbitai

Actionable comments posted: 1

♻️ Duplicate comments (1)

.github/workflows/deploy-pr.yml (1)

133-134: Fix negative/invalid route priorities (duplicate of earlier review).

NEXT_PRIORITY can become negative when no rules or when min=0. Clamp to non‑negative as previously noted.

Apply one of these minimal fixes:

-          export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 0' config.yml)
-          export NEXT_PRIORITY=$((MIN_PRIORITY - 1))
+          export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 1' config.yml)
+          if [ "$MIN_PRIORITY" -le 0 ]; then
+            export NEXT_PRIORITY=0
+          else
+            export NEXT_PRIORITY=$((MIN_PRIORITY - 1))
+          fi

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2b31903 and 3874095.

📒 Files selected for processing (1)

.github/workflows/deploy-pr.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build / Build Docker Images (linux/amd64, amd64)
GitHub Check: Cursor Bugbot

🔇 Additional comments (3)

.github/workflows/deploy-pr.yml (3)

105-112: Staging project scoping looks correct.

Using GCP_PROJECT=ghost-activitypub-stg for test DB cleanup is consistent and safe here.

117-117: Consistent GCP project for LB update.

Good: the URL‑map step now also derives project scope from GCP_PROJECT=ghost-activitypub-stg.

125-126: Good: backend service URLs parameterized by project.

DEFAULT_SERVICE and PR_SERVICE now derive from ${GCP_PROJECT}. Verify the backend service names exist in that project/region.

coderabbitai · 2025-10-13T14:29:03Z

.github/workflows/deploy-pr.yml

          for LABEL in $(echo "$LABELS_JSON" | jq -r '.[]'); do
            echo "Adding route for label: $LABEL"
-            yq -i '.pathMatchers[0].routeRules += [{"priority": '$NEXT_PRIORITY', "matchRules": [{"prefixMatch": "/", "headerMatches": [{ "headerName": "X-Forwarded-Host", "exactMatch": "'$LABEL'" }]}], "routeAction": {"weightedBackendServices": [ { "backendService": "'$PR_SERVICE'", "weight": 100 } ] }, "headerAction": { "requestHeadersToAdd": [ { "headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}" }, { "headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}" } ] } }]' config.yml
+            yq -i '.pathMatchers[0].routeRules = [{"priority": ${NEXT_PRIORITY}, "matchRules": [{"prefixMatch": "/", "headerMatches": [{"headerName": "X-Forwarded-Host", "exactMatch": ${LABEL}}]}], "routeAction": {"weightedBackendServices": [{"backendService": ${PR_SERVICE}, "weight": 100}]}, "headerAction": {"requestHeadersToAdd": [{"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"}, {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}]}}] + .pathMatchers[0].routeRules' config.yml


⚠️ Potential issue | 🔴 Critical

Blocking: yq command won’t expand ${...} due to single quotes; LABEL isn’t exported.

The single‑quoted yq program prevents shell expansion of ${NEXT_PRIORITY}, ${LABEL}, ${PR_SERVICE}, causing a parse error and empty values. Pass vars via env and use yq env/strenv.

Apply this diff:

- yq -i '.pathMatchers[0].routeRules = [{"priority": ${NEXT_PRIORITY}, "matchRules": [{"prefixMatch": "/", "headerMatches": [{"headerName": "X-Forwarded-Host", "exactMatch": ${LABEL}}]}], "routeAction": {"weightedBackendServices": [{"backendService": ${PR_SERVICE}, "weight": 100}]}, "headerAction": {"requestHeadersToAdd": [{"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"}, {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}]}}] + .pathMatchers[0].routeRules' config.yml + LABEL="$LABEL" yq -i '.pathMatchers[0].routeRules = ([{ + "priority": (env(NEXT_PRIORITY) | tonumber), + "matchRules": [{ + "prefixMatch": "/", + "headerMatches": [{ + "headerName": "X-Forwarded-Host", + "exactMatch": strenv(LABEL) + }] + }], + "routeAction": { + "weightedBackendServices": [{ + "backendService": strenv(PR_SERVICE), + "weight": 100 + }] + }, + "headerAction": { + "requestHeadersToAdd": [ + {"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"}, + {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"} + ] + } + }] + .pathMatchers[0].routeRules)' config.yml

Notes:

Prefix LABEL=... to export it for this command.

Use env(NEXT_PRIORITY)|tonumber for numeric priority.

Use strenv(...) for strings to avoid YAML parsing surprises.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

yq -i '.pathMatchers[0].routeRules = [{"priority": ${NEXT_PRIORITY}, "matchRules": [{"prefixMatch": "/", "headerMatches": [{"headerName": "X-Forwarded-Host", "exactMatch": ${LABEL}}]}], "routeAction": {"weightedBackendServices": [{"backendService": ${PR_SERVICE}, "weight": 100}]}, "headerAction": {"requestHeadersToAdd": [{"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"}, {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}]}}] + .pathMatchers[0].routeRules' config.yml

LABEL="$LABEL" yq -i '.pathMatchers[0].routeRules = ([{

"priority": (env(NEXT_PRIORITY) | tonumber),

"matchRules": [{

"prefixMatch": "/",

"headerMatches": [{

"headerName": "X-Forwarded-Host",

"exactMatch": strenv(LABEL)

}]

}],

"routeAction": {

"weightedBackendServices": [{

"backendService": strenv(PR_SERVICE),

"weight": 100

}]

},

"headerAction": {

"requestHeadersToAdd": [

{"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"},

{"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}

]

}

}] + .pathMatchers[0].routeRules)' config.yml

🤖 Prompt for AI Agents

.github/workflows/deploy-pr.yml around line 138: the current yq invocation is single-quoted so shell variables (${NEXT_PRIORITY}, ${LABEL}, ${PR_SERVICE}) are not expanded and LABEL is not exported; fix by exporting LABEL before the command (prefix LABEL=...), and rewrite the yq expression to use yq's env() and strenv() functions (e.g. env(NEXT_PRIORITY)|tonumber for numeric priority and strenv(...) for string values) so variables are passed via environment rather than relying on shell expansion and to avoid YAML parsing issues.

coderabbitai

Actionable comments posted: 0

♻️ Duplicate comments (1)

.github/workflows/deploy-pr.yml (1)

133-140: Fix priority math, avoid negative/duplicate priorities, remove brittle yq quoting, and stop assuming pathMatchers[0]

NEXT_PRIORITY can be -1; also incrementing it per label can collide with existing min priority.
Single-quoted yq with inline shell interpolation is brittle; pass vars via env and use yq env/strenv.
Do not assume .pathMatchers[0] is "all-paths"; select by name.

Use label count to allocate unique priorities strictly below existing min, clamp at 0, update the matcher by name, and pass vars via env:

-          export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 0' config.yml)
-          export NEXT_PRIORITY=$((MIN_PRIORITY - 1))
-          LABELS_JSON=$(echo "$LABELS" | jq -c '[.[] | select(.name | test("\\.ghost\\.is$")) | .name]')
-          for LABEL in $(echo "$LABELS_JSON" | jq -r '.[]'); do
-            echo "Adding route for label: $LABEL"
-            yq -i '.pathMatchers[0].routeRules = [{"priority": '${NEXT_PRIORITY}', "matchRules": [{"prefixMatch": "/", "headerMatches": [{"headerName": "X-Forwarded-Host", "exactMatch": "'"${LABEL}"'"}]}], "routeAction": {"weightedBackendServices": [{"backendService": "'"${PR_SERVICE}"'", "weight": 100}]}, "headerAction": {"requestHeadersToAdd": [{"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"}, {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}]}}] + .pathMatchers[0].routeRules' config.yml
-            export NEXT_PRIORITY=$((NEXT_PRIORITY + 1))
-          done
+          LABELS_JSON=$(echo "$LABELS" | jq -c '[.[] | select(.name | test("\\.ghost\\.is$")) | .name]')
+          LABEL_COUNT=$(echo "$LABELS_JSON" | jq 'length')
+          export MIN_PRIORITY=$(yq '[.pathMatchers[] | select(.name == "all-paths") | .routeRules[]?.priority] | min // 1' config.yml)
+          if [ "$MIN_PRIORITY" -le 0 ]; then
+            export BASE_PRIORITY=0
+          else
+            # Allocate a contiguous block below existing min to avoid collisions
+            if [ "$LABEL_COUNT" -gt 0 ]; then
+              export BASE_PRIORITY=$((MIN_PRIORITY - LABEL_COUNT))
+            else
+              export BASE_PRIORITY=$((MIN_PRIORITY - 1))
+            fi
+            if [ "$BASE_PRIORITY" -lt 0 ]; then
+              export BASE_PRIORITY=0
+            fi
+          fi
+          i=0
+          for LABEL in $(echo "$LABELS_JSON" | jq -r '.[]'); do
+            PRI=$((BASE_PRIORITY + i))
+            echo "Adding route for label: $LABEL with priority $PRI"
+            LABEL="$LABEL" PRI="$PRI" yq -i '
+              .pathMatchers |= map(
+                if .name == "all-paths" then
+                  .routeRules = ([{
+                    "priority": (env(PRI) | tonumber),
+                    "matchRules": [{
+                      "prefixMatch": "/",
+                      "headerMatches": [{
+                        "headerName": "X-Forwarded-Host",
+                        "exactMatch": strenv(LABEL)
+                      }]
+                    }],
+                    "routeAction": {
+                      "weightedBackendServices": [{
+                        "backendService": strenv(PR_SERVICE),
+                        "weight": 100
+                      }]
+                    },
+                    "headerAction": {
+                      "requestHeadersToAdd": [
+                        {"headerName": "X-ActivityPub-PR", "headerValue": "${{ github.event.pull_request.number }}"},
+                        {"headerName": "X-ActivityPub-Commit", "headerValue": "${{ github.event.pull_request.head.sha }}"}
+                      ]
+                    }
+                  }] + .routeRules)
+                else .
+                end
+              )' config.yml
+            i=$((i + 1))
+          done

Notes:

min // 1 avoids negative when empty; BASE_PRIORITY block guarantees unique, non-negative priorities.
strenv(...) and env(...) remove quoting pitfalls and ensure correct types.
Selecting by name avoids relying on index order.

🧹 Nitpick comments (1)

.github/workflows/deploy-pr.yml (1)

106-111: Harden loop over test DB names

Quote expansions to avoid word-splitting and handle empty sets safely.

Apply:

-          TEST_DATABASES=$(gcloud sql databases list --instance=stg-netherlands-activitypub --filter="name~pr_${{ github.event.pull_request.number }}_test*" --format="value(name)" --project ${GCP_PROJECT})
-          for TEST_DATABASE in ${TEST_DATABASES}; do
-            gcloud sql databases delete ${TEST_DATABASE} --instance=stg-netherlands-activitypub --quiet --project ${GCP_PROJECT}
-          done
+          TEST_DATABASES="$(gcloud sql databases list --instance=stg-netherlands-activitypub --filter="name~pr_${{ github.event.pull_request.number }}_test*" --format="value(name)" --project "${GCP_PROJECT}")"
+          if [ -n "$TEST_DATABASES" ]; then
+            while IFS= read -r TEST_DATABASE; do
+              [ -z "$TEST_DATABASE" ] && continue
+              gcloud sql databases delete "$TEST_DATABASE" --instance=stg-netherlands-activitypub --quiet --project "${GCP_PROJECT}"
+            done <<< "$TEST_DATABASES"
+          fi

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e83b100 and ae6e62e.

📒 Files selected for processing (1)

.github/workflows/deploy-pr.yml (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: build / Build Docker Images (linux/amd64, amd64)
GitHub Check: Cursor Bugbot

🔇 Additional comments (1)

.github/workflows/deploy-pr.yml (1)

125-127: Good: service URIs now derive from GCP_PROJECT

DEFAULT_SERVICE and PR_SERVICE correctly use ${GCP_PROJECT}, eliminating the project mismatch risk.

mike182uk temporarily deployed to staging September 25, 2025 16:15 — with GitHub Actions Inactive

sagzy approved these changes Oct 2, 2025

View reviewed changes

Updated client config controller to reference updated script name

09f052a

ref https://linear.app/ghost/issue/PROD-2455 ref TryGhost/Ghost#24985 The `admin-x-activitypub` script has been renamed to just `activitypub` so the client config endpoint should be updated to reflect this change

mike182uk force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from 2e37743 to 09f052a Compare October 9, 2025 11:57

mike182uk temporarily deployed to staging October 9, 2025 12:15 — with GitHub Actions Inactive

TryGhost deleted a comment from cursor bot Oct 9, 2025

mike182uk added apdevstaging.ghost.is skip-tests and removed apdevstaging.ghost.is labels Oct 9, 2025

mike182uk had a problem deploying to staging October 9, 2025 16:28 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 9, 2025 16:30 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 9, 2025 16:40 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 10, 2025 07:15 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 10, 2025 07:17 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 10, 2025 07:20 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 13, 2025 06:27 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 13, 2025 06:32 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 13, 2025 06:35 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 13, 2025 09:33 — with GitHub Actions Failure

mike182uk had a problem deploying to staging October 13, 2025 09:36 — with GitHub Actions Failure

Temporary fix for ephemeral PR deployment

8b88cac

This comment was marked as outdated.

Sign in to view

mike182uk had a problem deploying to staging October 13, 2025 10:05 — with GitHub Actions Failure

Fixed load balancer gcp project

f41f728

rmgpinto temporarily deployed to staging October 13, 2025 10:25 — with GitHub Actions Inactive

rmgpinto had a problem deploying to staging October 13, 2025 12:31 — with GitHub Actions Failure

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from 9195985 to a57802f Compare October 13, 2025 12:42

rmgpinto had a problem deploying to staging October 13, 2025 12:47 — with GitHub Actions Failure

coderabbitai bot reviewed Oct 13, 2025

View reviewed changes

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from a57802f to 2b31903 Compare October 13, 2025 14:11

rmgpinto had a problem deploying to staging October 13, 2025 14:16 — with GitHub Actions Failure

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from 2b31903 to 3874095 Compare October 13, 2025 14:19

rmgpinto had a problem deploying to staging October 13, 2025 14:25 — with GitHub Actions Failure

coderabbitai bot reviewed Oct 13, 2025

View reviewed changes

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from 3874095 to e83b100 Compare October 13, 2025 14:31

rmgpinto had a problem deploying to staging October 13, 2025 14:36 — with GitHub Actions Failure

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from e83b100 to 7b790b0 Compare October 13, 2025 14:38

This comment was marked as outdated.

Sign in to view

rmgpinto had a problem deploying to staging October 13, 2025 14:44 — with GitHub Actions Failure

Changed priority on load balancer

ae6e62e

rmgpinto force-pushed the mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost branch from 7b790b0 to ae6e62e Compare October 13, 2025 14:46

rmgpinto temporarily deployed to staging October 13, 2025 14:53 — with GitHub Actions Inactive

coderabbitai bot reviewed Oct 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Updated client config controller to reference updated script name #1330

Updated client config controller to reference updated script name #1330

Uh oh!

mike182uk commented Sep 25, 2025

Uh oh!

coderabbitai bot commented Sep 25, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

This comment was marked as outdated.

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 13, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Oct 13, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		export MIN_PRIORITY=$(yq '[.pathMatchers[] \| select(.name == "all-paths") \| .routeRules[]?.priority] \| min // 0' config.yml)
		export NEXT_PRIORITY=$((MIN_PRIORITY - 1))

Uh oh!

Updated client config controller to reference updated script name #1330

Are you sure you want to change the base?

Updated client config controller to reference updated script name #1330

Uh oh!

Conversation

mike182uk commented Sep 25, 2025

Uh oh!

coderabbitai bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

This comment was marked as outdated.

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Sep 25, 2025 •

edited

Loading