Renamed TopContentStatsService to ContentStatsService
#23148
Conversation
|
""" WalkthroughThe changes involve renaming the Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
cmraible
force-pushed
the
rename-top-content-service
branch
from
ae74817 to
23b5588
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/core/core/server/services/stats/ContentStatsService.js(12 hunks)ghost/core/core/server/services/stats/StatsService.js(6 hunks)ghost/core/test/unit/server/services/stats/content.test.js.js(20 hunks)
🔇 Additional comments (11)
ghost/core/test/unit/server/services/stats/content.test.js.js (4)
3-3: Import path correctly updated.The import statement has been updated to reflect the renamed service.
38-42: Service instantiation correctly updated.The service instantiation has been properly updated to use the renamed class.
162-165: Service without urlService instantiation correctly updated.The service instantiation without the urlService has been properly updated to use the renamed class.
422-425: Service without Tinybird client instantiation correctly updated.The service instantiation without the Tinybird client has been properly updated to use the renamed class.
ghost/core/core/server/services/stats/ContentStatsService.js (2)
12-12: Class name correctly renamed.The class has been properly renamed from
TopContentStatsServicetoContentStatsServiceto align with the service's broader functionality and naming patterns in the codebase.
196-196: Module export correctly updated.The module export has been properly updated to export the renamed class.
ghost/core/core/server/services/stats/StatsService.js (5)
6-6: Import statement correctly updated.The import statement has been properly updated to use the renamed service.
17-17: JSDoc annotation correctly updated.The JSDoc annotation has been properly updated to reflect the renamed service.
70-70: Method call correctly updated.The method call has been properly updated to use the renamed property.
80-80: Method call correctly updated.The method call has been properly updated to use the renamed property.
114-115: Service instantiation correctly updated.The service instantiation in the static
createmethod has been properly updated to use the renamed class.
cmraible
force-pushed
the
rename-top-content-service
branch
from
fd700f7 to
9af2131
Compare
cmraible
force-pushed
the
rename-top-content-service
branch
from
9af2131 to
8f71a31
Compare
cmraible
changed the title
TopContentStatsService to ContentStatsService
no refs
Renaming this service and its test files to align with the pattern in the other stats services. There are likely to be other content endpoints that aren't necessarily
top-*, which can be added to this service and given their own endpoints.