Skip to content

Added is all of operator to member label filters#27944

Closed
kevinansfield wants to merge 1 commit into
TryGhost:mainfrom
kevinansfield:codex/ber-3664-member-label-is-all
Closed

Added is all of operator to member label filters#27944
kevinansfield wants to merge 1 commit into
TryGhost:mainfrom
kevinansfield:codex/ber-3664-member-label-is-all

Conversation

@kevinansfield

Copy link
Copy Markdown
Member

Summary

  • Added an is all of operator to member Label filters
  • Serialized all-of label filters as grouped NQL, e.g. (label:alpha+label:vip)
  • Preserved ungrouped repeated label filters as separate filter rows when parsing back to UI state

Issue

ref https://linear.app/ghost/issue/BER-3664/add-is-all-of-operator-to-member-label-filters

Validation

  • pnpm --filter @tryghost/posts exec vitest run src/views/members/member-filter-query.test.ts src/views/filters/filter-codecs.test.ts src/views/members/member-fields.test.ts src/views/members/use-member-filter-fields.test.ts
  • pnpm --filter @tryghost/posts build

ref https://linear.app/ghost/issue/BER-3664/add-is-all-of-operator-to-member-label-filters

Members need to filter for contacts that have every selected label, while preserving existing any-of and none-of semantics and round-tripping grouped NQL back into the filter UI.
@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ce20b08-9f63-4300-ba5c-b7bcb6d62ee7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@kevinansfield

Copy link
Copy Markdown
Member Author

Closing because this PR was accidentally opened from my fork. Replaced by upstream-backed draft PR #27945.

@kevinansfield kevinansfield deleted the codex/ber-3664-member-label-is-all branch May 18, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant