Skip to content

Fix CI/CD pipeline and PyPI publish failures - #27

Merged
Tsadoq merged 2 commits into
mainfrom
fix/komoot-api-compatibility
Apr 13, 2026
Merged

Fix CI/CD pipeline and PyPI publish failures#27
Tsadoq merged 2 commits into
mainfrom
fix/komoot-api-compatibility

Conversation

@Tsadoq

@Tsadoq Tsadoq commented Apr 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix fit_tool version pin (0.9.13 unavailable → 0.9.14)
  • Extract _validate_sport_types helper to bring get_tours cyclomatic complexity under flake8 limit of 25
  • Lowercase package name (Kompykompy) for PyPI normalization
  • Bump version to 0.0.13 to avoid re-upload 400 error
  • Change publish workflow trigger from every push to main to GitHub release events only

Test plan

  • new_code_checks workflow passes (flake8 + tests)
  • docs-generation workflow passes
  • python-publish workflow no longer triggers on push to main — verify it only fires on a GitHub Release

- Lowercase package name (Kompy -> kompy) for PyPI normalization
- Bump version to 0.0.13 to avoid re-upload conflict
- Trigger publish only on GitHub release instead of every push to main
@Tsadoq
Tsadoq requested a review from Copilot April 13, 2026 08:50
@Tsadoq
Tsadoq merged commit 8195caf into main Apr 13, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates packaging metadata and the PyPI publish workflow to address CI/CD and publishing failures.

Changes:

  • Lowercase the distribution name in pyproject.toml and bump version to 0.0.13 for PyPI publishing.
  • Update the PyPI publish GitHub Actions workflow to run only on GitHub Release publish events.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Adjusts project name casing and increments version to avoid PyPI re-upload conflicts.
.github/workflows/python-publish.yml Changes the publish trigger from push on main to release (published) events.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 9 to +13
name: Upload Python Package to PyPI

on:
push:
branches:
- main
release:
types: [published]

Copilot AI Apr 13, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow header comment says the package is uploaded "when a release is created", but the trigger is now release with types: [published]. Consider updating the comment to match the new behavior (published releases only) to avoid confusion when debugging pipeline runs.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants