Fix CI/CD pipeline and PyPI publish failures - #27
Merged
Conversation
- Lowercase package name (Kompy -> kompy) for PyPI normalization - Bump version to 0.0.13 to avoid re-upload conflict - Trigger publish only on GitHub release instead of every push to main
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates packaging metadata and the PyPI publish workflow to address CI/CD and publishing failures.
Changes:
- Lowercase the distribution name in
pyproject.tomland bump version to0.0.13for PyPI publishing. - Update the PyPI publish GitHub Actions workflow to run only on GitHub Release publish events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Adjusts project name casing and increments version to avoid PyPI re-upload conflicts. |
.github/workflows/python-publish.yml |
Changes the publish trigger from push on main to release (published) events. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
+13
| name: Upload Python Package to PyPI | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
The workflow header comment says the package is uploaded "when a release is created", but the trigger is now release with types: [published]. Consider updating the comment to match the new behavior (published releases only) to avoid confusion when debugging pipeline runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fit_toolversion pin (0.9.13 unavailable → 0.9.14)_validate_sport_typeshelper to bringget_tourscyclomatic complexity under flake8 limit of 25Kompy→kompy) for PyPI normalizationmainto GitHub release events onlyTest plan
new_code_checksworkflow passes (flake8 + tests)docs-generationworkflow passespython-publishworkflow no longer triggers on push to main — verify it only fires on a GitHub Release