Fix CompareMPS when files differ in length #1190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the files had different length, the script prints errors, but was not returning errors. This returns the correct exit flag. We also update the message to make it easier to find the comment and try to avoid duplicate CompareMPS messages. Finally, we clarify that forks won't have the messages. Closes #1188
abelsiqueira
force-pushed
the
1188-mps-false-positive-if-files-differ
branch
from
78cf982 to
e9f1285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the files had different length, the script prints errors,
but was not returning errors. This returns the correct
exit flag.
Related issues
Closes #1188
Checklist