Change import to using in test

[clizbe]

Related issues

Closes #42

Checklist

• I am following the contributing guidelines
• Tests are passing
• Lint workflow is passing
• Docs were updated and workflow is passing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.91%. Comparing base (6bc433b) to head (7100bd9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files           6        6           
  Lines         266      266           
=======================================
  Hits          178      178           
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[suvayu]

Ah, I think you tagged me for review just after I went on holiday :-p

I don't recollect exactly, but wasn't the convention to not use using Module but using Module: name1, name2, ... instead? The rationale being, the first form imports everything into the namespace, whereas the second only imports the names we need explicitly; explicit > implicit.

[clizbe]

@abelsiqueira
I can't remember either. I just followed what I saw in another repo and tried to make it work. (I don't understand the difference between the methods.)

[suvayu]

IIRC, import name means now you can define overloads for name (i.e. type dispatch), but using prevents that. So doing using is preferred unless you are extending something. But only doing using module imports all exported names from the module, which we don't want since that's implicit.

[clizbe]

Here's the full conversation:
TulipaEnergy/TulipaEnergyModel.jl#431

Here's the decision.

After some exploration, I suggest using Package: Package, some_stuff.

• using Package: Package will import the module name, so it can be used for prefixing non-imported stuff.
• using Package: some_stuff will load some_stuff, which will permit using some_stuff without the prefix. I recommend this for obvious cases (such as JuMP's macros), or functions with explicit names (can't think of any right now).
• For some stuff, don't explicitly load it. Instead, when using it, prefix with the package name. For instance, Graphs.edges.

[clizbe]

@abelsiqueira @suvayu
Maybe we should make an exception for TulipaIO and TulipaEnergyModel, with:

import TulipaIO as TIO
import TulipaEnergyModel as TEM

Or is that extra confusing? Just asking because the names are quite long otherwise and I don't think you can use as with using.

[clizbe]

For now I'm leaving it explicit at TulipaIO.whatever which I think is actually nice - at least in the tests.