-
-
Notifications
You must be signed in to change notification settings - Fork 14
Added <hr> tag functionlity #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vishalk91-4
wants to merge
6
commits into
TurboDocx:main
Choose a base branch
from
Vishalk91-4:vishal/hr-tag
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3ecb7d4
Added <hr> tag functionlity
Vishalk91-4 8a868ff
Added parameter and constants for hr styles
Vishalk91-4 874210f
Added style properties of hr rule
Vishalk91-4 812e1ac
Added Parameters and style attributes
Vishalk91-4 b33bd80
Fixed breaking changes of docx, making changes to buildhorizontalRule
Vishalk91-4 29606e0
Added fragments to fix height and border
Vishalk91-4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
// render-document-file.js | ||
/* eslint-disable no-await-in-loop */ | ||
/* eslint-disable no-case-declarations */ | ||
import { fragment } from 'xmlbuilder2'; | ||
|
@@ -19,6 +20,7 @@ import { vNodeHasChildren } from '../utils/vnode'; | |
import { isValidUrl } from '../utils/url'; | ||
import { getMimeType } from '../utils/image'; | ||
import { cloneDeep } from 'lodash'; | ||
import { buildHorizontalRule } from '../helpers/xml-builder'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. although I like this syntax better, for now to keep it consistent, follow the syntax of how the xmlBuilder is imported on line 15. EG |
||
|
||
const convertHTML = HTMLToVDOM({ | ||
VNode, | ||
|
@@ -309,6 +311,10 @@ async function findXMLEquivalent(docxDocumentInstance, vNode, xmlFragment) { | |
const linebreakFragment = await xmlBuilder.buildParagraph(null, {}); | ||
xmlFragment.import(linebreakFragment); | ||
return; | ||
case 'hr': | ||
const hrFragment = buildHorizontalRule(vNode, vNode.properties.style); | ||
xmlFragment.import(hrFragment); | ||
return; | ||
case 'head': | ||
return; | ||
} | ||
|
@@ -353,4 +359,4 @@ async function renderDocumentFile(docxDocumentInstance) { | |
return populatedXmlFragment; | ||
} | ||
|
||
export default renderDocumentFile; | ||
export default renderDocumentFile; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, we want to make sure everything is resolved