-
-
Notifications
You must be signed in to change notification settings - Fork 14
fix: pass missing docxDocumentInstance to buildRun() inside blockquote building branch #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…te building branch
Hi @adymo can you make a git issue and explain the bug, repro, and then I can understand better how to test this fix |
Just created an issue #65 |
tested this, it works |
On deck to be released -- sorry for the delays on our end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue in the blockquote branch of the paragraph builder where the docxDocumentInstance was not passed to buildRun, ensuring that blockquote elements render correctly with proper formatting and media handling. Additionally, example files have been updated to demonstrate blockquote usage.
- Passes docxDocumentInstance to buildRun for blockquote nodes.
- Updates example files (React, plain JS, and Node) to include a blockquote usage example.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/helpers/xml-builder.js | Fixes missing docxDocumentInstance argument in buildRun for blockquote. |
example/react-example/src/App.js | Adds a blockquote element example. |
example/example.js | Adds a blockquote element example. |
example/example-node.js | Adds a blockquote element example. |
Comments suppressed due to low confidence (1)
src/helpers/xml-builder.js:1413
- The change correctly passes docxDocumentInstance to buildRun for blockquote handling. Please verify that similar calls in other branches consistently pass all required parameters.
const runFragmentOrFragments = await buildRun(vNode, attributes, docxDocumentInstance);
@yacineKahlerras @adymo I am not seeing the difference here? Before is from our develop branch, after is from this fork. Is there another example that can show this? |
@@ -23,6 +23,7 @@ const htmlString = `<!DOCTYPE html> | |||
src="https://upload.wikimedia.org/wikipedia/commons/4/47/PNG_transparency_demonstration_1.png" | |||
alt="Red dot" | |||
/> | |||
<blockquote>Quote <span>from <a href="https://www.wikipedia.org/">Wikipedia</a></span></blockquote> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See other comment, unable to see this in the document and not seeing it render in the document.xml
No description provided.