Skip to content

fix: pass missing docxDocumentInstance to buildRun() inside blockquote building branch #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adymo
Copy link
Contributor

@adymo adymo commented Apr 11, 2025

No description provided.

@nicolasiscoding
Copy link
Member

Hi @adymo can you make a git issue and explain the bug, repro, and then I can understand better how to test this fix

@adymo
Copy link
Contributor Author

adymo commented Apr 17, 2025

Just created an issue #65

@yacineKahlerras
Copy link

tested this, it works

@nicolasiscoding
Copy link
Member

On deck to be released -- sorry for the delays on our end

@nicolasiscoding nicolasiscoding requested a review from Copilot May 7, 2025 23:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in the blockquote branch of the paragraph builder where the docxDocumentInstance was not passed to buildRun, ensuring that blockquote elements render correctly with proper formatting and media handling. Additionally, example files have been updated to demonstrate blockquote usage.

  • Passes docxDocumentInstance to buildRun for blockquote nodes.
  • Updates example files (React, plain JS, and Node) to include a blockquote usage example.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/helpers/xml-builder.js Fixes missing docxDocumentInstance argument in buildRun for blockquote.
example/react-example/src/App.js Adds a blockquote element example.
example/example.js Adds a blockquote element example.
example/example-node.js Adds a blockquote element example.
Comments suppressed due to low confidence (1)

src/helpers/xml-builder.js:1413

  • The change correctly passes docxDocumentInstance to buildRun for blockquote handling. Please verify that similar calls in other branches consistently pass all required parameters.
const runFragmentOrFragments = await buildRun(vNode, attributes, docxDocumentInstance);

@nicolasiscoding
Copy link
Member

nicolasiscoding commented May 7, 2025

@yacineKahlerras @adymo I am not seeing the difference here?

image

image

image

Before is from our develop branch, after is from this fork.

Is there another example that can show this?

@nicolasiscoding nicolasiscoding self-requested a review May 7, 2025 23:12
@nicolasiscoding nicolasiscoding added the bug Something isn't working label May 7, 2025
@@ -23,6 +23,7 @@ const htmlString = `<!DOCTYPE html>
src="https://upload.wikimedia.org/wikipedia/commons/4/47/PNG_transparency_demonstration_1.png"
alt="Red dot"
/>
<blockquote>Quote <span>from <a href="https://www.wikipedia.org/">Wikipedia</a></span></blockquote>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comment, unable to see this in the document and not seeing it render in the document.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants