files.js -- Update with code from Files Expanded #1833
Conversation
SharkPool-SP
changed the title
|
!format |
|
Related PR: #1594 |
CubesterYT
added
pr: change existing extension
|
|
Ah, someone that actually knows what they are doing. I'm just going to close mine, since this does everything that mine would do (and better). |
|
Renamed the branch, reopen the PR from |
|
!format |
|
!format |
| fileDate = "", | ||
| lastData = ""; | ||
| let openModals = 0; | ||
| let selectorOptions = { |
There was a problem hiding this comment.
is there a reason you cant just make this a constant
| if (override === "folder") { | ||
| fileInfo = await window.showDirectoryPicker({ | ||
| multiple: false, | ||
| types: [{ accept: { "*/*": [] } }], |
There was a problem hiding this comment.
is there a reason you cant accept other types
| * @param {Uint8Array} buffer | ||
| * @returns {string} base64 | ||
| */ | ||
| function bufferToBase64(buffer) { |
There was a problem hiding this comment.
this seems wasteful and copied from stackoverflow, is there a reason you cant use the globally exposed Base64 module
| const picker = await showFilePrompt("Folder", "", "folder"); | ||
| if (!picker) return; | ||
|
|
||
| const createExtFile = async (folderN, data) => { |
There was a problem hiding this comment.
is there a reason these have to be inlined instead of just functions on the class itself
| @@ -444,7 +1117,242 @@ | |||
| console.warn(`unknown mode`, args.mode); | |||
| } | |||
| } | |||
|
|
|||
| fileInfo(args) { | |||
| if (args.FORMAT === "size formatted") return FileSize; | |||
There was a problem hiding this comment.
checking again you dont cast anything in your new changes, that should be fixed
| selectorOptions.image = `url(${encodeURI(args.IMG)})`; | ||
| updateModalVisuals(); | ||
| } else { | ||
| console.warn("Cannot fetch content from the URL."); |
There was a problem hiding this comment.
there's no reason to console.warn but okay
Super Mega Update to the Files Extension to port over many new features from my expansion of the extension.
This includes:
Closes:
#1603
#156
#837
Files Expanded:
https://github.com/SharkPool-SP/SharkPools-Extensions/blob/main/extension-code/Files-Expanded.js