Skip to content

(W.I.P) New Extension: Pretty Blocks #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

hammouda101010
Copy link

@hammouda101010 hammouda101010 commented Mar 5, 2025

Pretty Blocks

This is an extension that lets you add formatting and format checking to your project much like Prettier.
It's also extensible (lets you create your custom rules), can import format plugins from URLs, can be used programaticaly and also has it's own custom "programming language" named "RegBool" that looks like this:
if <true> /true/ else false

Here are the features to finish:

  • Format checking
  • Formatting
  • Expand "RegBool"'s Syntax
  • Custom Plugins

I might note that this extension uses custom modal patches to show format errors and creating custom rules inside modals

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Mar 5, 2025
@Brackets-Coder
Copy link
Contributor

Here a few seconds after this PR was made

Copy link
Member

@yuri-kiss yuri-kiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the same boat as anything else that uses patches.

As'well as this is the TurboWarp gallery, the support for other mods is more work for US to maintain, it should be removed.

@hammouda101010
Copy link
Author

hammouda101010 commented Mar 8, 2025

This is in the same boat as anything else that uses patches.

As'well as this is the TurboWarp gallery, the support for other mods is more work for US to maintain, it should be removed.

so. technically, this extension won't be accepted due to the use of patches?
for the other mods support removal i can do that but i'll probably won't remove the patches (atleast the modal patches)

@hammouda101010
Copy link
Author

hammouda101010 commented Mar 8, 2025

so. technically, this extension won't be accepted due to the use of patches? for the other mods support removal i can do that but i'll probably won't remove the patches (atleast the modal patches)

i might possibly know that using patches might be buggy and also dangerous, but atleast you shoud've added some API to do this.

you've also accepted @SharkPool-SP's Camera V2 extension, which (somewhat) uses patches to create new (builtin) modals.
that's kind of unfair.

like maybe add a way to create custom modals to add HTML elements to the modal, or add more types of modals.

@SharkPool-SP
Copy link
Collaborator

so. technically, this extension won't be accepted due to the use of patches? for the other mods support removal i can do that but i'll probably won't remove the patches (atleast the modal patches)

i might possibly know that using patches might be buggy and also dangerous, but atleast you shoud've added some API to do this.

you've also accepted @SharkPool-SP's Camera V2 extension, which (somewhat) uses patches to create new (builtin) modals.

that's kind of unfair.

like maybe add a way to create custom modals to add HTML elements to the modal, or add more types of modals.

Camera V2 was merged to fix camera v1. And the only way to make a proper camera system was with patches.

Additionally, the modal in the camera v2 extension isn't patched. It just calls the function with the appropriate settings.

@yuri-kiss
Copy link
Member

yuri-kiss commented Mar 9, 2025

but atleast you shoud've added some API to do this.

no, thats not how that works, we dont cater to every single possible need some random developer may have
if its useful, and someone wants it as an API, it can be added (WITH TIME)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants