DogeisCut/FormatNumbers: Resolve AD notation inconsistencies #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was not intentional.
- Fixed the comment ID to match the extension ID. - Structured long arrays in format function vertically for consistency. - Re-ordered placement of extension (I recall being told not to worry about this?)
wow im glad this completley undid the vertical consistency you asked me to do.......
Resolves: TurboWarp#2328 Results: 10^33: 1Dc 10^36: 1 UDc 10^45: 1 QaDc 10^48: 1 QnDc See https://pastebin.com/JpUFnLtp for full results, please let me know if you see anything wrong as I can not locate the resource I was previously using to verify this.
github-actions
bot
added
the
pr: change existing extension
PPPDUD
previously requested changes
Nov 18, 2025
Member
PPPDUD
left a comment
PPPDUD
left a comment
There was a problem hiding this comment.
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
You should assign the corrected block to a different opcode so that it doesn't break old projects reliant on broken behavior.
Member
|
Projects relying on clearly broken behavior are not "well-formed" |
Contributor
Author
I concur, which is precisely why I didn't make a new block for the fix. |
Member
Fair. I'm still witholding my approval, but I don't object to someone else approving it and merging. |
GarboMuffin
approved these changes
Nov 18, 2025
CubesterYT
approved these changes
Nov 18, 2025
Member
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
GarboMuffin
changed the title
GarboMuffin
changed the title
CubesterYT
dismissed
PPPDUD’s stale review
"Fair. I'm still witholding my approval, but I don't object to someone else approving it and merging."
Going to need to dismiss to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2328
Results:
10^33: 1Dc
10^36: 1 UDc
10^45: 1 QaDc
10^48: 1 QnDc
See https://pastebin.com/JpUFnLtp for full results, please let me know if you see anything wrong as I can not locate the resource I was previously using to verify this.