Lily/Skins: fix undefined function call #2336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
GarboMuffin
force-pushed
the
lily-skins-udnefined-function-fix
branch
from
457f785 to
7d8492a
Compare
DogeisCut
approved these changes
Nov 25, 2025
Contributor
DogeisCut
left a comment
DogeisCut
left a comment
There was a problem hiding this comment.
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
CubesterYT
approved these changes
Nov 25, 2025
Member
CubesterYT
left a comment
CubesterYT
left a comment
There was a problem hiding this comment.
- I tested all modified functionality and found no bugs or unintuitive behavior.
- I believe a well-formed project using an older version of this extension will not be broken by this new version.
- I have no additional concerns.
GarboMuffin
added a commit
that referenced
this pull request
Nov 30, 2025
#2336 is an example of a bug that type checking would've stopped. To work towards adding type checking warnings, this PR adds a globals.d.ts defining some APIs that are missing from regular TypeScript and adjusts a few extensions to remove a few warnings. If you read the extension changes, you should be able to convince yourself that this change has no affect on extension behavior and doesn't need any testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeDispose function does not exist. It meant to say _disposeSafe