Add PR annotations for validate, format, and types #2345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
GarboMuffin
force-pushed
the
pr-annotations
branch
2 times, most recently
from
cf18441 to
e60fc09
Compare
GarboMuffin
force-pushed
the
pr-annotations
branch
from
e60fc09 to
39333f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint errors already show up in the GitHub changes view. This makes errors from the validate, format, and a new type checking step also show up inline when applicable. Type checking has hundreds of false positives so it's not required to pass. It'll also only show warnings from files modified by the PR.
GitHub's annotation feature is very poorly designed and implemented, so this has a lot of restrictions, such as 10 annotation limit per job. Anything beyond that is silently ignored because of course. (This also isn't documented in GitHub's user-facing docs anywhere, because again of course)