Allow adding custom shadow argument reporters (SB part) #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to have this as a property on the block, and then register an extension (like |
This comment was marked as abuse.
This comment was marked as abuse.
Member
|
it is better for this to be set declaratively on the block in getInfo() then the vm will forward it along |
This comment was marked as abuse.
This comment was marked as abuse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VM: TurboWarp/scratch-vm#246
Resolves
Having to do a weird patch for it.
Proposed Changes
Allows you to add your own custom shadow argument reporters. (reporters that duplicate when they are shadowed and dragged)
Reason for Changes
See #Resolves
Test Coverage
No tests, this is very simple