-
Notifications
You must be signed in to change notification settings - Fork 37
Use ALL_MODELS rather than DEMO_MODELS #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Report
Computer InformationBenchmark Results |
|
DynamicPPL.jl documentation for PR #1173 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 78.95% 78.90% -0.06%
==========================================
Files 41 41
Lines 3896 3910 +14
==========================================
+ Hits 3076 3085 +9
- Misses 820 825 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
penelopeysm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks great!
Co-authored-by: Penelope Yong <[email protected]>
We define a number of models in TestUtils. Most of them are collected in the constant
DEMO_MODELS, namely all the ones representing the one model with an InverseGamma and all that. However, there are a few other models as well. This PR collects all of them in a new constantALL_MODELS, and starts using that in the test suite wherever the test isn't specific to the particular statistical model thatDEMO_MODELimplements. It also fixes various issues that this expansion of the test suite brought up.That this wasn't done before is the reason that in #1150 the issue with ranges wasn't caught by the test suite.
Not yet ready for review, need to understand remaining test failures.