Skip to content

Seed RNG inside model_dimension() #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented May 16, 2025

Closes #905. The problem is that there were certain parameter values that would cause link(vi, model) to fail.

Copy link
Contributor

github-actions bot commented May 16, 2025

Benchmark Report for Commit 6571a5a

Computer Information

Julia Version 1.11.5
Commit 760b2e5b739 (2025-04-14 06:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 4 × AMD EPYC 7763 64-Core Processor
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Benchmark Results

|                 Model | Dimension |  AD Backend |      VarInfo Type | Linked | Eval Time / Ref Time | AD Time / Eval Time |
|-----------------------|-----------|-------------|-------------------|--------|----------------------|---------------------|
| Simple assume observe |         1 | forwarddiff |             typed |  false |                  9.6 |                 3.7 |
|           Smorgasbord |       201 | forwarddiff |             typed |  false |                725.9 |                36.1 |
|           Smorgasbord |       201 | forwarddiff | simple_namedtuple |   true |                433.4 |                47.2 |
|           Smorgasbord |       201 | forwarddiff |           untyped |   true |               1233.6 |                28.8 |
|           Smorgasbord |       201 | forwarddiff |       simple_dict |   true |               3837.9 |                21.8 |
|           Smorgasbord |       201 | reversediff |             typed |   true |               1438.2 |                29.3 |
|           Smorgasbord |       201 |    mooncake |             typed |   true |                948.4 |                 5.2 |
|    Loop univariate 1k |      1000 |    mooncake |             typed |   true |               5414.7 |                 4.1 |
|       Multivariate 1k |      1000 |    mooncake |             typed |   true |               1139.3 |                 7.9 |
|   Loop univariate 10k |     10000 |    mooncake |             typed |   true |              59887.5 |                 3.8 |
|      Multivariate 10k |     10000 |    mooncake |             typed |   true |              10148.6 |                 8.5 |
|               Dynamic |        10 |    mooncake |             typed |   true |                142.9 |                11.6 |
|              Submodel |         1 |    mooncake |             typed |   true |                 12.8 |                 6.8 |
|                   LDA |        12 | reversediff |             typed |   true |                449.0 |                 5.7 |

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (cdeb657) to head (6571a5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #923   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files          35       35           
  Lines        3924     3924           
=======================================
  Hits         3336     3336           
  Misses        588      588           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15075859865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-4.9%) to 80.215%

Files with Coverage Reduction New Missed Lines %
ext/DynamicPPLEnzymeCoreExt.jl 1 0.0%
ext/DynamicPPLForwardDiffExt.jl 1 63.64%
src/sampler.jl 1 89.23%
src/simple_varinfo.jl 1 75.14%
src/varnamedvector.jl 1 89.36%
src/contexts.jl 2 74.79%
src/logdensityfunction.jl 2 52.27%
src/model.jl 2 84.17%
src/utils.jl 2 73.8%
src/values_as_in_model.jl 3 59.52%
Totals Coverage Status
Change from base Build 14935073817: -4.9%
Covered Lines: 3138
Relevant Lines: 3912

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 16, 2025

Pull Request Test Coverage Report for Build 15075859865

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 22 unchanged lines in 11 files lost coverage.
  • Overall coverage remained the same at 85.102%

Files with Coverage Reduction New Missed Lines %
ext/DynamicPPLEnzymeCoreExt.jl 1 0.0%
ext/DynamicPPLForwardDiffExt.jl 1 63.64%
src/sampler.jl 1 89.23%
src/simple_varinfo.jl 1 75.14%
src/varnamedvector.jl 1 89.36%
src/contexts.jl 2 74.79%
src/logdensityfunction.jl 2 52.27%
src/model.jl 2 84.17%
src/utils.jl 2 73.8%
src/values_as_in_model.jl 3 59.52%
Totals Coverage Status
Change from base Build 14935073817: 0.0%
Covered Lines: 3336
Relevant Lines: 3920

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks fails indeterministically
2 participants