Skip to content

Conversation

@shravanngoswamii
Copy link
Member

@shravanngoswamii shravanngoswamii commented Jan 5, 2026

Save MCMCChains objects as:

Partially completes #499

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 61.11111% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.37%. Comparing base (6b95633) to head (bc5bfe8).

Files with missing lines Patch % Lines
src/fileio.jl 0.00% 17 Missing ⚠️
ext/MCMCChainsJSONExt.jl 89.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #502      +/-   ##
==========================================
+ Coverage   88.35%   88.37%   +0.02%     
==========================================
  Files          20       21       +1     
  Lines        1365     1402      +37     
==========================================
+ Hits         1206     1239      +33     
- Misses        159      163       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

MCMCChains.jl documentation for PR #502 is available at:
https://TuringLang.github.io/MCMCChains.jl/previews/PR502/

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented way to define JSON (de)serialization for custom types seems to be to define JSON.lower: https://juliaio.github.io/JSON.jl/dev/writing/#Custom-Type-Serialization-with-lower

@shravanngoswamii
Copy link
Member Author

Thank you, @devmotion! I have updated the extension to define JSON.lower for custom types.

@yebai
Copy link
Member

yebai commented Jan 14, 2026

note that ArivZ conversion already exist, see https://github.com/arviz-devs/ArviZ.jl/blob/ffd94133ba9f081930b32af05dc901bd19dfd42e/ext/ArviZMCMCChainsExt.jl#L103

@yebai
Copy link
Member

yebai commented Jan 14, 2026

cc @nsiccha as this will implement StanCSV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants