-
Notifications
You must be signed in to change notification settings - Fork 31
Add feature to save MCMCChains objects as JSON #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 88.35% 88.37% +0.02%
==========================================
Files 20 21 +1
Lines 1365 1402 +37
==========================================
+ Hits 1206 1239 +33
- Misses 159 163 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
15fa73d to
9596b48
Compare
|
MCMCChains.jl documentation for PR #502 is available at: |
devmotion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documented way to define JSON (de)serialization for custom types seems to be to define JSON.lower: https://juliaio.github.io/JSON.jl/dev/writing/#Custom-Type-Serialization-with-lower
|
Thank you, @devmotion! I have updated the extension to define |
|
note that ArivZ conversion already exist, see https://github.com/arviz-devs/ArviZ.jl/blob/ffd94133ba9f081930b32af05dc901bd19dfd42e/ext/ArviZMCMCChainsExt.jl#L103 |
|
cc @nsiccha as this will implement StanCSV. |
Save MCMCChains objects as:
ArviZ InferenceObjectsSee here.Partially completes #499