-
Notifications
You must be signed in to change notification settings - Fork 231
Enable keyword arguments for particle methods #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9c66ef2 to
8b4e7f2
Compare
| ) | ||
| printstyled( | ||
| ctx, | ||
| " using Libtask; Libtask.@might_produce($(model.f))"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could/should reexport Libtask.@might_produce or something similar from Turing, to make it easier?
6dd26db to
c94c5fa
Compare
|
Turing.jl documentation for PR #2660 is available at: |
c94c5fa to
f533de2
Compare
| [sources] | ||
| AdvancedPS = {url = "https://github.com/TuringLang/AdvancedPS.jl", rev = "py/kwargs"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will have to be removed pending release of TuringLang/AdvancedPS.jl#118
| [sources] | ||
| AdvancedPS = {url = "https://github.com/TuringLang/AdvancedPS.jl", rev = "py/kwargs"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2660 +/- ##
===========================================
- Coverage 86.51% 55.75% -30.77%
===========================================
Files 20 20
Lines 1261 1259 -2
===========================================
- Hits 1091 702 -389
- Misses 170 557 +387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mhauru @sunxd3 this should be ready now that TuringLang/AdvancedPS.jl#118 is released. |
Note
This PR requires some changes to AdvancedPS. TuringLang/AdvancedPS.jl#118
It also needs the following Libtask patch: TuringLang/Libtask.jl#198This is mergedThis PR also lacks tests; some should be added.Tests added.This PR allows models with keyword arguments to be run with SMC / PG.
Example:
Closes #2007.