Test on 1.10.11 and 1.13#2791
Closed
penelopeysm wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2791 +/- ##
=======================================
Coverage 86.44% 86.44%
=======================================
Files 22 22
Lines 1446 1446
=======================================
Hits 1250 1250
Misses 196 196 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Turing.jl documentation for PR #2791 is available at: |
Member
Author
|
Spoiler alert; it wasn't fixed in 1.10.11..... sigh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a minimum Julia compat bound of 1.10.8. That is technically fine, but running CI on 1.10.8 causes an indeterministic segfault (#2655), which (to my understanding) has been patched in 1.10.11 (see JuliaLang/julia#54840).
I don't think that this is enough to justify bumping the minimum version in Project.toml to 1.10.11; but we can run CI on 1.10.11 to avoid this failure from messing CI up.
Closes #2655
This PR also enables testing on 1.13, since we can now refer to it with 'pre'.