Remove unnecessary hacks in Gibbs interface#2811
Merged
Merged
Conversation
penelopeysm
commented
Apr 22, 2026
Comment on lines
-24
to
-31
| # TODO(penelopeysm): This field is needed for Gibbs because each time we call | ||
| # gibbs_update_state!! on this, we need to reconstruct a LogDensityFunction. | ||
| # In general this would require reevaluating the model, unless we supply a | ||
| # VarNamedTuple which already contains vectorised parameters. This can probably | ||
| # be improved in DynamicPPL, but for now we will just store an extra VNT in | ||
| # the state. | ||
| # NOTE: The actual values of this field should never be used or relied on! | ||
| _vector_vnt::V |
Member
Author
There was a problem hiding this comment.
basically this PR is just getting rid of this field which should not need to exist
Contributor
|
Turing.jl documentation for PR #2811 is available at: |
Member
Author
|
Once this passes, I'll release 0.44. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## breaking #2811 +/- ##
============================================
- Coverage 85.33% 85.23% -0.10%
============================================
Files 22 22
Lines 1493 1483 -10
============================================
- Hits 1274 1264 -10
Misses 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.