Make client warn when network message from server are missings #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a player try to connect to a halplibe server and the server got some network message that the player don't have.
Currently Minecraft will show an error screen because the network message the client try to reconstruct don't exist.
This is an unwanted behavior since with network message with halplibe we want to be table to create network message on server even if client can't receive it for usecase as sending a compatible UniversalPacket or a deeper relation between specific client that the server know.
So this PR change the runtime error with a simple warning on the client when the client can't create the NetworkMessage. This mean the client could connect to the game without having every network message.
Please note this don't mean you can always connect to a server without the client having the mod if for exemple the server send unknown recipes to the client
Example :
