Skip to content

[TT-17218] Test variation #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konrad-sol merged 2 commits into from
Jun 23, 2026
Merged

[TT-17218] Test variation #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31fb34c
change default in test-controller-action to default
konrad-sol Jun 18, 2026
328d8aa
use pump and sink values from envfiles in env up action
konrad-sol Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/tests/env-up/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,10 @@
confs_dir=./pro-ha
env_file=local.env' >> versions.env
if [[ $REPO_NAME != "tyk-pump" ]]; then
tyk_pump_image=${{ matrix.pump }}
tyk_pump_image=${{ matrix.envfiles.pump || matrix.pump }}
fi
if [[ $REPO_NAME != "tyk-sink" ]]; then
tyk_sink_image=${{ matrix.sink }}
tyk_sink_image=${{ matrix.envfiles.sink || matrix.sink }}

Check failure on line 99 in .github/actions/tests/env-up/action.yaml

View check run for this annotation

probelabs / Visor: security

security Issue 

The values from the GitHub Actions context (`matrix.envfiles.pump`, `matrix.pump`, `matrix.envfiles.sink`, `matrix.sink`) are directly interpolated into a shell script without being quoted. This can lead to command injection if the context values contain shell metacharacters. An attacker who can control these values could execute arbitrary commands in the CI runner.
Raw output 
Always quote variables that are derived from external inputs when used in shell commands to prevent word splitting and command injection. Enclose the GitHub Actions expressions in double quotes.
fi
cat ./confs/${{ matrix.envfiles.config }}.env local-${{ matrix.envfiles.db }}.env > local.env
echo "::group::versions"
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/tests/test-controller/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
fallback_ref:
description: 'Branch to fall back to when base_ref has no config in the API'
required: false
default: 'master'
default: 'default'

Check warning on line 17 in .github/actions/tests/test-controller/action.yaml

View check run for this annotation

probelabs / Visor: quality

documentation Issue 

The default value for `fallback_ref` was changed to `'default'`. Since `'default'` is not typically a valid branch name, the input's description, "Branch to fall back to when base_ref has no config in the API", has become misleading. This could cause confusion for developers using or maintaining this action, as the expected value is not just a branch.
Raw output 
Update the description for `fallback_ref` to clarify that it accepts special values like `'default'` in addition to branch names. For example: "A reference, such as a branch name, to fall back to when `base_ref` has no configuration in the API. The special value 'default' can be used to instruct the API to use its own default configuration."
outputs:
envfiles:
description: 'Environment files for the test'
Expand Down
Loading