fix: generate TUI static files for both singular and plural variation names#445
Open
probelabs[bot] wants to merge 1 commit intomasterfrom
Open
fix: generate TUI static files for both singular and plural variation names#445probelabs[bot] wants to merge 1 commit intomasterfrom
probelabs[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Task
The TUI static site generator in
policy/tui.goexplicitly strips the trailingsfrom the filename when generating static files. This means it only generates files under thev2/prod-variation/...path. However,tyk-prousesVARIATION: prod-variationsin its workflows, so it requestsv2/prod-variations/...which returns a 404 Not Found, causing pipeline failures.Changes
GenerateStaticinpolicy/tui.goto generate static files for both the singular and plural forms of the variation name (e.g.,prod-variationandprod-variations).Testing
gromit/policyand they pass.