Skip to content

fix: fix the wrong error return value#429

Open
drawdrop wants to merge 1 commit into
TykTechnologies:masterfrom
drawdrop:master
Open

fix: fix the wrong error return value#429
drawdrop wants to merge 1 commit into
TykTechnologies:masterfrom
drawdrop:master

Conversation

@drawdrop

@drawdrop drawdrop commented Mar 3, 2025

Copy link
Copy Markdown

Description

In fact, err is incorrect and should be jsErr.

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

Signed-off-by: drawdrop <cricis@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant