[TT-14473] - support for encrypted aws kinesis #876
Closed
probelabs / Visor: performance
succeeded
Oct 9, 2025 in 4m 59s
✅ Check Passed (Warnings Found)
performance check passed. Found 1 warning, but fail_if condition was not met.
Details
📊 Summary
- Total Issues: 1
- Warning Issues: 1
🐛 Issues by Category
⚡ Performance (1)
⚠️ pumps/kinesis.go:94 - The new logic to enable server-side encryption introduces blocking network calls (DescribeStreamandStartStreamEncryption) within theInitfunction. This will increase the application's startup time whenever aKMSKeyIDis configured, as the pump must wait for responses from the AWS API before it can start processing data. In environments with slow network connectivity to AWS, this could lead to noticeable delays in service availability during deployments or restarts.
Generated by Visor - AI-powered code review
Annotations
Check warning on line 129 in pumps/kinesis.go
probelabs / Visor: performance
performance Issue
The new logic to enable server-side encryption introduces blocking network calls (`DescribeStream` and `StartStreamEncryption`) within the `Init` function. This will increase the application's startup time whenever a `KMSKeyID` is configured, as the pump must wait for responses from the AWS API before it can start processing data. In environments with slow network connectivity to AWS, this could lead to noticeable delays in service availability during deployments or restarts.
Raw output
While the current fail-safe approach is robust, consider adding a log entry at the beginning of the check to indicate that the pump is verifying Kinesis encryption. This would make it clear to operators why startup might be delayed. For example: `p.log.Info("Verifying Kinesis stream encryption...")`. No major architectural change is recommended as the current approach is safe, but awareness of the startup delay is important.
Loading