[TT-15560] added batchbytes configs and unit testing for kafka #889
+241
−2
probelabs / Visor: security
succeeded
Oct 13, 2025 in 5m 1s
✅ Check Passed (Warnings Found)
security check passed. Found 2 warnings, but fail_if condition was not met.
Details
📊 Summary
- Total Issues: 2
- Warning Issues: 2
🐛 Issues by Category
🔐 Security (1)
⚠️ pumps/kafka.go:185 - Thebatch_bytesconfiguration parameter lacks an upper limit. A malicious or misconfigured user could provide an extremely large value, causing the application to allocate excessive memory for the message batch. This could lead to an Out-of-Memory (OOM) error, resulting in a Denial of Service (DoS).
🧠 Logic (1)
⚠️ pumps/kafka.go:186 - The application handles an invalid negativebatch_bytesconfiguration by logging an error and then proceeding with a default value (0). This approach can mask configuration issues, as the error may be missed in logs, leading the service to run with unintended performance characteristics. A better practice for invalid configuration is to fail fast.
Generated by Visor - AI-powered code review
Annotations
Check warning on line 189 in pumps/kafka.go
probelabs / Visor: security
security Issue
The `batch_bytes` configuration parameter lacks an upper limit. A malicious or misconfigured user could provide an extremely large value, causing the application to allocate excessive memory for the message batch. This could lead to an Out-of-Memory (OOM) error, resulting in a Denial of Service (DoS).
Raw output
Implement a validation check to enforce a reasonable maximum value for `batch_bytes`. If the configured value exceeds this limit, the pump should either cap the value at the maximum and log a warning, or return an error during initialization to prevent starting with a potentially dangerous configuration.
Check warning on line 187 in pumps/kafka.go
probelabs / Visor: security
logic Issue
The application handles an invalid negative `batch_bytes` configuration by logging an error and then proceeding with a default value (0). This approach can mask configuration issues, as the error may be missed in logs, leading the service to run with unintended performance characteristics. A better practice for invalid configuration is to fail fast.
Raw output
Instead of logging and continuing, return an error from the `Init` function when `k.kafkaConf.BatchBytes` is negative. This ensures that the application will not start in a misconfigured state, making the problem immediately apparent to the operator.
Loading