Skip to content

[TT-11125] Add trace_id to traffic logs #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lghiur wants to merge 1 commit into from

[TT-11125] Add trace_id to traffic logs

8941d7f
Select commit
Loading
Failed to load commit list.
Closed

[TT-11125] Add trace_id to traffic logs #899

[TT-11125] Add trace_id to traffic logs
8941d7f
Select commit
Loading
Failed to load commit list.
probelabs / Visor: performance succeeded Oct 2, 2025 in 4m 46s

✅ Check Passed (Warnings Found)

performance check passed. Found 1 warning, but fail_if condition was not met.

Details

📊 Summary

  • Total Issues: 3
  • Warning Issues: 1

🐛 Issues by Category

⚡ Performance (3)

  • ⚠️ analytics/analytics.go:78 - The new TraceID field, mapped to the traceid database column, is a high-cardinality field that will likely be used for filtering. Queries against this column without an index will cause full table scans, leading to significant performance degradation on large datasets.
  • ℹ️ analytics/analytics.go:78 - The addition of the TraceID string field to the AnalyticsRecord struct increases its memory footprint. While the per-record increase is small, the cumulative effect can be significant in a high-throughput environment, leading to higher overall memory consumption for the application.
  • ℹ️ analytics/analytics_test.go:179 - The new test for RemoveIgnoredFields highlights a pre-existing performance issue. This function uses reflection in a nested loop for every analytics record, which is inefficient and can cause CPU overhead on a hot path.

Generated by Visor - AI-powered code review

Annotations

Check warning on line 78 in analytics/analytics.go

See this annotation in the file changed.

@probelabs probelabs / Visor: performance

performance Issue 

The new `TraceID` field, mapped to the `traceid` database column, is a high-cardinality field that will likely be used for filtering. Queries against this column without an index will cause full table scans, leading to significant performance degradation on large datasets.
Raw output 
Add a database index to the `traceid` column for all supported SQL databases. This should be noted in documentation and included in any database migration scripts.

Check notice on line 78 in analytics/analytics.go

See this annotation in the file changed.

@probelabs probelabs / Visor: performance

performance Issue 

The addition of the `TraceID` string field to the `AnalyticsRecord` struct increases its memory footprint. While the per-record increase is small, the cumulative effect can be significant in a high-throughput environment, leading to higher overall memory consumption for the application.
Raw output 
This is an acceptable trade-off for the new functionality, but the impact on memory usage should be considered for capacity planning in high-volume deployments.

Check notice on line 185 in analytics/analytics_test.go

See this annotation in the file changed.

@probelabs probelabs / Visor: performance

performance Issue 

The new test for `RemoveIgnoredFields` highlights a pre-existing performance issue. This function uses reflection in a nested loop for every analytics record, which is inefficient and can cause CPU overhead on a hot path.
Raw output 
Consider optimizing `RemoveIgnoredFields` by building a map of JSON tags to struct fields upon pump initialization. This would change the lookup from a slow O(N) iteration to a fast O(1) map lookup per field, reducing CPU usage for users of the field-ignoring feature.
View more details on probelabs