[TT-15243] Influx2 latency metric #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

andrei-tyk merged 2 commits into master from influx2-latency-metric

Oct 9, 2025

Merged

[TT-15243] Influx2 latency metric #900

Merge branch 'master' into influx2-latency-metric

probelabs / Visor: style succeeded Oct 8, 2025 in 4m 54s

✅ Check Passed (Warnings Found)

style check passed. Found 1 warning, but fail_if condition was not met.

Details

📊 Summary

Total Issues: 1
Warning Issues: 1

🐛 Issues by Category

🎨 Style (1)

⚠️ pumps/influx2_test.go:32 - The test TestInflux2PumpMappingIncludesLatency duplicates the mapping logic from pumps/influx2.go instead of testing the production code directly. This makes the test brittle, as changes in the production mapping logic will not be caught by this test, and the test itself will need to be manually kept in sync.

Generated by Visor - AI-powered code review

Annotations

Check warning on line 49 in pumps/influx2_test.go

probelabs / Visor: style

style Issue

The test `TestInflux2PumpMappingIncludesLatency` duplicates the mapping logic from `pumps/influx2.go` instead of testing the production code directly. This makes the test brittle, as changes in the production mapping logic will not be caught by this test, and the test itself will need to be manually kept in sync.

Raw output


            Refactor the mapping creation in `pumps/influx2.go` into a separate, testable function. This new function can then be called from both the `WriteData` method and this test, ensuring the test validates the actual production logic and improving maintainability.

View more details on probelabs