Skip to content

[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 1 commit into from
Apr 17, 2026

fix: prevent dep-guard from skipping downstream jobs on push

90c92b2
Select commit
Loading
Failed to load commit list.
Merged

[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push #971

fix: prevent dep-guard from skipping downstream jobs on push
90c92b2
Select commit
Loading
Failed to load commit list.
probelabs / Visor: performance failed Apr 17, 2026 in 1m 29s

🚨 Check Failed

performance check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 2
  • Error Issues: 2

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Logic (2)

  • ❌ .github/workflows/release.yml:315 - The condition github.event.pull_request.draft == false will evaluate to false on push events because the github.event.pull_request context object is null. This will prevent this job and other downstream jobs (api-tests, test-controller-distros, upgrade-deb, upgrade-rpm) from running on push triggers. This appears to contradict the pull request's stated goal of ensuring these jobs run on push events.
  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 315 in .github/workflows/release.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: performance

logic Issue 

The condition `github.event.pull_request.draft == false` will evaluate to `false` on `push` events because the `github.event.pull_request` context object is null. This will prevent this job and other downstream jobs (`api-tests`, `test-controller-distros`, `upgrade-deb`, `upgrade-rpm`) from running on `push` triggers. This appears to contradict the pull request's stated goal of ensuring these jobs run on push events.
Raw output 
To allow the job to run on both `push` events and non-draft `pull_request` events, the condition should explicitly check the event type. Replace `github.event.pull_request.draft == false` with `github.event_name == 'push' || github.event.pull_request.draft == false` in all the newly added `if` blocks for the affected jobs.
View more details on probelabs