Skip to content

[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 1 commit into from
Apr 17, 2026
+22 −3

fix: prevent dep-guard from skipping downstream jobs on push

561024f
Select commit
Loading
Failed to load commit list.
Merged

[TT-16977] fix: prevent dep-guard from skipping downstream jobs on push #972

fix: prevent dep-guard from skipping downstream jobs on push
561024f
Select commit
Loading
Failed to load commit list.
probelabs / Visor: quality failed Apr 17, 2026 in 40s

🚨 Check Failed

quality check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 2
  • Error Issues: 2

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Logic (2)

  • ❌ .github/workflows/release.yml:398 - The aggregator-ci-status job's needs are updated to include dep-guard, but the corresponding run script that checks job statuses has not been updated. The script's required_jobs variable (not visible in the diff) still only lists goreleaser and api-tests. Consequently, a failure in the dep-guard job will not be detected by this aggregate status check, potentially leading to a misleading "success" status for pull requests where dep-guard fails.
  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 398 in .github/workflows/release.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

logic Issue 

The `aggregator-ci-status` job's `needs` are updated to include `dep-guard`, but the corresponding `run` script that checks job statuses has not been updated. The script's `required_jobs` variable (not visible in the diff) still only lists `goreleaser` and `api-tests`. Consequently, a failure in the `dep-guard` job will not be detected by this aggregate status check, potentially leading to a misleading "success" status for pull requests where `dep-guard` fails.
Raw output 
Modify the `run` script within the `aggregator-ci-status` job to include `dep-guard` in the `required_jobs` variable to ensure its status is correctly aggregated.
View more details on probelabs