Skip to content

Merging to release-1.14.1: Update gorm and storage deps (#977)#981

Merged
buger merged 1 commit intorelease-1.14.1from
merge/release-1.14.1/5781f05ece80b88b9b2bbfefd4bcac351038e421/TT-16932
Apr 17, 2026
Merged

Merging to release-1.14.1: Update gorm and storage deps (#977)#981
buger merged 1 commit intorelease-1.14.1from
merge/release-1.14.1/5781f05ece80b88b9b2bbfefd4bcac351038e421/TT-16932

Conversation

@probelabs
Copy link
Copy Markdown
Contributor

@probelabs probelabs bot commented Apr 17, 2026

Update gorm and storage deps (#977)

  • update gorm to master

  • update storage

* update gorm to master

* update storage

(cherry picked from commit 5781f05)
@probelabs probelabs bot mentioned this pull request Apr 17, 2026
14 tasks
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: c5c9bd0
Failed at: 2026-04-17 18:28:25 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to get Jira issue: failed to fetch Jira issue TT-16932: Issue does not exist or you do not have permission to see it.: request failed. Please analyze the request body for more details. Status code: 404

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@probelabs
Copy link
Copy Markdown
Contributor Author

probelabs bot commented Apr 17, 2026

This pull request updates two core dependencies: github.com/TykTechnologies/storage and a fork of gorm.io/gorm. These changes are confined to the go.mod and go.sum files, reflecting a version bump for both libraries.

Files Changed Analysis

  • go.mod: The version for github.com/TykTechnologies/storage is updated from v1.3.0 to v1.3.1. The replace directive for gorm.io/gorm is updated to a newer commit hash from the TykTechnologies/gorm fork.
  • go.sum: Checksums have been updated to match the new dependency versions, which is an expected change.

Architecture & Impact Assessment

This PR updates foundational libraries for data persistence within Tyk Pump.

  • What this PR accomplishes: It incorporates the latest changes from the storage and gorm libraries, likely bringing in bug fixes or minor enhancements.
  • Key technical changes:
    • github.com/TykTechnologies/storage is bumped from v1.3.0 to v1.3.1.
    • gorm.io/gorm is updated to commit d6d1a2e12d9d from the TykTechnologies/gorm fork.
  • Affected system components:
    • The gorm update directly impacts all SQL-based pumps (PostgreSQL, MySQL), which use it as their ORM for storing analytics and uptime data. Affected files include pumps/sql.go, pumps/graph_sql.go, and their aggregate counterparts.
    • The storage library update affects the MongoDB pumps (pumps/mongo.go, pumps/graph_mongo.go, etc.) which use it for persisting analytics records.
graph TD
    subgraph Tyk Pump
        A[SQL Pumps] --> B[gorm.io/gorm];
        C[Mongo Pumps] --> D[TykTechnologies/storage];
    end

    subgraph Dependencies
        B -- Updated to new commit --> E[SQL Databases];
        D -- Updated v1.3.0 to v1.3.1 --> F[MongoDB];
    end
Loading

Scope Discovery & Context Expansion

The impact of this PR is determined by the changes within the updated dependencies. Given the minor version bump in storage and a new commit for gorm, the changes are likely non-breaking bug fixes.

  • The gorm update will affect all components that interact with SQL databases for writing analytics records.
  • The storage update will affect all components relying on the MongoDB driver for data persistence.

While the changes in this repository are minimal, a thorough review would involve examining the changelogs for TykTechnologies/storage v1.3.1 and the commit history of the TykTechnologies/gorm fork to ensure no regressions are introduced.

Metadata
  • Review Effort: 1 / 5
  • Primary Label: chore

Powered by Visor from Probelabs

Last updated: 2026-04-17T18:29:51.387Z | Triggered by: pr_opened | Commit: c5c9bd0

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor Author

probelabs bot commented Apr 17, 2026

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Security Check Passed

No security issues found – changes LGTM.

\n\n

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

Performance Issues (2)

Severity Location Issue
🟡 Warning go.mod:10
The `gorm` dependency is being updated. As `gorm` is used for database operations, including writing analytics data in `pumps/sql.go` and `pumps/graph_sql.go`, this update could have performance implications. Without a detailed changelog for the specific commits, it's impossible to assess whether this change introduces performance improvements or regressions. The update is to a forked repository, which adds to the uncertainty.
💡 SuggestionReview the changes between the old and new commits in the `github.com/TykTechnologies/gorm` repository to ensure no performance regressions were introduced. Specifically, check for changes in query generation, connection handling, or transaction management that could affect the `WriteData` functions in `pumps/sql.go` and `pumps/graph_sql.go`. If possible, run performance benchmarks for analytics processing before and after this change.
🟡 Warning go.mod:7
The `github.com/TykTechnologies/storage` dependency is updated from v1.3.0 to v1.3.1. This library is used for Redis connectivity, which is a critical component for `tyk-pump`'s data processing pipeline. Performance changes in the storage library could impact throughput and latency. The contents of this minor version update are unknown, presenting a potential performance risk.
💡 SuggestionExamine the changelog or commit history for `github.com/TykTechnologies/storage` between versions v1.3.0 and v1.3.1 to identify any changes that might affect performance, such as modifications to connection pooling, command execution, or data serialization. Performance testing of the data pump under load is recommended to validate the impact of this update.

Powered by Visor from Probelabs

Last updated: 2026-04-17T18:29:41.694Z | Triggered by: pr_opened | Commit: c5c9bd0

💡 TIP: You can chat with Visor using /visor ask <your question>

@buger buger merged commit 45fe611 into release-1.14.1 Apr 17, 2026
19 of 23 checks passed
@buger buger deleted the merge/release-1.14.1/5781f05ece80b88b9b2bbfefd4bcac351038e421/TT-16932 branch April 17, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants