Fix release pipelines to pick up latest Go patch TT-16060 #7512
probelabs / Visor: architecture
failed
Nov 6, 2025 in 4m 51s
🚨 Check Failed
architecture check failed because fail_if condition was met.
Details
📊 Summary
- Total Issues: 3
- Error Issues: 2
- Warning Issues: 1
🔍 Failure Condition Results
❌ Failed Conditions
- global_fail_if: Global failure condition met
⚠️ Severity: Error
🐛 Issues by Category
🏗️ Architecture (2)
- ❌ .github/workflows/release.yml:128 - The GitHub Actions workflow contains significant duplication in the Docker build and push logic for 'ee', 'fips', and 'std' images. The steps for metadata generation, building, and pushing to CI and production registries are repeated three times with only minor variations in names and labels.
⚠️ .github/workflows/release.yml:129 - The workflow uses a hardcoded Go version string '1.24-bookworm' in multiple 'if' conditions. This creates a maintenance burden, as every instance will need to be updated when the Go version in the matrix changes.
🧠 Logic (1)
- ❌ system:0 - Global failure condition met
Powered by Visor from Probelabs
💡 TIP: You can chat with Visor using /visor ask <your question>
Annotations
Check failure on line 356 in .github/workflows/release.yml
probelabs / Visor: architecture
architecture Issue
The GitHub Actions workflow contains significant duplication in the Docker build and push logic for 'ee', 'fips', and 'std' images. The steps for metadata generation, building, and pushing to CI and production registries are repeated three times with only minor variations in names and labels.
Raw output
To improve maintainability and reduce redundancy, refactor the duplicated logic into a reusable component. This can be achieved using a GitHub Actions matrix strategy with different parameters for each image type, or by creating a separate reusable workflow (`workflow_call`) that accepts the image type, package name, and other variables as inputs. A reusable workflow is often cleaner for complex, multi-step logic like this.
Check warning on line 129 in .github/workflows/release.yml
probelabs / Visor: architecture
architecture Issue
The workflow uses a hardcoded Go version string '1.24-bookworm' in multiple 'if' conditions. This creates a maintenance burden, as every instance will need to be updated when the Go version in the matrix changes.
Raw output
Since the matrix currently contains only one Go version, these 'if' conditions are redundant and can be removed. If the intent is to run these steps only for a specific 'primary' Go version when more versions are added to the matrix, define the primary version as a variable at the job or workflow level and reference that variable in the conditions. This avoids scattering the hardcoded version string throughout the file.
Loading