Skip to content

[TT-15426]fixed go.mod not having latest graphql-go-tools version #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrei-tyk merged 1 commit into from
Nov 12, 2025
Merged

[TT-15426]fixed go.mod not having latest graphql-go-tools version #7534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
github.com/TykTechnologies/goautosocket v0.0.0-20190430121222-97bfa5e7e481
github.com/TykTechnologies/gorpc v0.0.0-20250214161245-e9f3f088e8c6
github.com/TykTechnologies/goverify v0.0.0-20220808203004-1486f89e7708
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20250926102005-c54e73aae17d
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20251104074758-abfe5c458f3b

Check warning on line 28 in go.mod

View check run for this annotation

probelabs / Visor: quality

documentation Issue 

The pull request updates the `graphql-go-tools` dependency version without providing any reasoning or context. The description is minimal, and the checklist item 'I explained why this PR updates go.mod in detail with reasoning why it's required' is unchecked. Updating dependencies without justification introduces risk, as it can bring in breaking changes or new bugs without reviewers understanding the purpose.
Raw output 
Update the pull request description to explain why this dependency update is necessary. Clarify if it's for a bug fix, a new feature, or a security patch. Link to the relevant issue or changelog in the `graphql-go-tools` repository if possible.

Check warning on line 28 in go.mod

View check run for this annotation

probelabs / Visor: dependency

architecture Issue 

This PR updates the `github.com/TykTechnologies/graphql-go-tools` dependency. While this is a dependency-only change, it affects the core GraphQL engine and has downstream implications.

### Impact Assessment
- **Component Affected**: The GraphQL engine is the primary component affected. Based on the source branch name (`fix/allow-custom-scalars-extended`), this update likely enhances support for custom GraphQL scalars.
- **New Build**: This change will result in a new Tyk Gateway Docker image.

### Required Downstream Updates
- **`tyk-charts`**: The new gateway image tag generated from this change must be updated in the `tyk-charts` repository to ensure the change is deployed. This action is not part of the current PR and needs to be tracked separately.
Raw output 
Create a corresponding PR in the `tyk-charts` repository to update the Tyk Gateway image tag once this change is merged and a new image is built.
github.com/TykTechnologies/graphql-translator v0.0.0-20250602105400-41c2e7514a36

Check warning on line 29 in go.mod

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

The pull request updates the `graphql-go-tools` dependency to a newer commit-based version without providing any justification. The PR description is empty, and the checklist item for explaining `go.mod` changes is unchecked. Updating dependencies, especially to non-release versions, carries risks of introducing instability, bugs, or breaking changes. Without a clear explanation of what this new version fixes or enables, it's impossible to assess the architectural impact or the necessity of this change.
Raw output 
Update the pull request description to detail the reasons for this dependency update. Explain what changes are included in the new version of `graphql-go-tools` and why they are necessary for the `fix/allow-custom-scalars-extended` feature branch. Link to the specific changes in the dependency's repository if possible.
github.com/TykTechnologies/murmur3 v0.0.0-20230310161213-aad17efd5632

Check warning on line 30 in go.mod

View check run for this annotation

probelabs / Visor: security

security Issue 

The `graphql-go-tools` dependency is updated without a clear description of the changes or a security assessment. Dependency updates can introduce new vulnerabilities or fix existing ones, but without context, the security impact of this change cannot be evaluated.
Raw output 
The pull request description should be updated to include a summary of the changes in the new version of the dependency, especially any security-related fixes or features. A link to the changelog or the diff between the two commits (`c54e73aae17d` and `abfe5c458f3b`) in the `github.com/TykTechnologies/graphql-go-tools` repository should be provided. All dependency updates should be checked with a vulnerability scanner before being merged.
github.com/TykTechnologies/openid2go v0.1.2
github.com/TykTechnologies/storage v1.2.2
github.com/TykTechnologies/tyk-pump v1.13.0-rc2.0.20251023125113-bc7641d42e63
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,8 +814,8 @@ github.com/TykTechnologies/gorpc v0.0.0-20250214161245-e9f3f088e8c6 h1:wwt23wdyi
github.com/TykTechnologies/gorpc v0.0.0-20250214161245-e9f3f088e8c6/go.mod h1:v6v7Mlj08+EmEcXOfpuTxGt2qYU9yhqqtv4QF9Wf50E=
github.com/TykTechnologies/goverify v0.0.0-20220808203004-1486f89e7708 h1:cmXjlMzcexhc/Cg+QB/c2CPUVs1ux9xn6162qaf/LC4=
github.com/TykTechnologies/goverify v0.0.0-20220808203004-1486f89e7708/go.mod h1:mkS8jKcz8otdfEXhJs1QQ/DKoIY1NFFsRPKS0RwQENI=
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20250926102005-c54e73aae17d h1:2H3rZCU+VhlXQd/0zXMjhyFdT6cImGisDJXk/QsC3mY=
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20250926102005-c54e73aae17d/go.mod h1:bvVafmGebtdjIFG2bXkLd+O1jOjjU/3To+mQHcLr4KI=
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20251104074758-abfe5c458f3b h1:Qepgu3gphc87YOx7lQ66m5QRfhXy8Xy5PmSZf1qSOoc=
github.com/TykTechnologies/graphql-go-tools v1.6.2-0.20251104074758-abfe5c458f3b/go.mod h1:bvVafmGebtdjIFG2bXkLd+O1jOjjU/3To+mQHcLr4KI=
github.com/TykTechnologies/graphql-go-tools/v2 v2.0.0-20250926102005-c54e73aae17d h1:bK9T78hExbTuDK4UaBuGi9aL28hK68Uw3OyNZswdPcA=
github.com/TykTechnologies/graphql-go-tools/v2 v2.0.0-20250926102005-c54e73aae17d/go.mod h1:XM1owY0ZCJ1Rai64Q1UKXZYNDkWikZDojgefZw8raPk=
github.com/TykTechnologies/graphql-translator v0.0.0-20250602105400-41c2e7514a36 h1:7nNsyocI/RKBqo73RR9G/SiFMZ8w2sN+HMsQXYp9wPI=
Expand Down
Loading