Gromit sync with tyk repo TT-16131 #7542
Merged
probelabs / Visor: architecture
succeeded
Nov 18, 2025 in 3m 35s
✅ Check Passed (Warnings Found)
architecture check passed. Found 1 warning, but fail_if condition was not met.
Details
📊 Summary
- Total Issues: 1
- Warning Issues: 1
Issues by Category
Architecture (1)
⚠️ .github/workflows/release.yml:200 - The newly added steps for building and pushing the FIPS Docker image are a near-exact copy of the existing steps for theee(lines 131-197) andstd(lines 268-334) images. This introduces significant code duplication into the CI/CD pipeline, making it harder to maintain and increasing the risk of inconsistencies. A change in the build process would need to be replicated in three places.
Powered by Visor from Probelabs
💡 TIP: You can chat with Visor using /visor ask <your question>
Annotations
Check warning on line 265 in .github/workflows/release.yml
probelabs / Visor: architecture
architecture Issue
The newly added steps for building and pushing the FIPS Docker image are a near-exact copy of the existing steps for the `ee` (lines 131-197) and `std` (lines 268-334) images. This introduces significant code duplication into the CI/CD pipeline, making it harder to maintain and increasing the risk of inconsistencies. A change in the build process would need to be replicated in three places.
Raw output
To adhere to the DRY (Don't Repeat Yourself) principle, refactor the common Docker build-and-push logic into a reusable GitHub Actions workflow (`workflow_call`) or a composite action. This reusable component can then be called three times with different parameters for each image variant (`ee`, `fips`, `std`), such as the image name, build arguments, and labels. This will simplify the main workflow and centralize the build logic.
Loading