[TT-12827] A gateway using a redis rate limiter panics if any Gateway sharing the same Redis is using the DRL #7558
probelabs / Visor: quality
succeeded
Nov 25, 2025 in 54s
✅ Check Passed (Warnings Found)
quality check passed. Found 1 warning, but fail_if condition was not met.
Details
📊 Summary
- Total Issues: 1
- Warning Issues: 1
🔍 Failure Condition Results
Passed Conditions
- global_fail_if: Condition passed
Issues by Category
Architecture (1)
⚠️ gateway/gateway_test.go:641 - The sub-tests inTestDistributedRateLimiterDisabledRedisEventsmodify a sharedglobalConfvariable across test cases. This pattern is fragile and prevents tests from being run in parallel safely. Each sub-test should manage its own state and ensure proper cleanup to maintain test isolation.
Powered by Visor from Probelabs
💡 TIP: You can chat with Visor using /visor ask <your question>
Annotations
Check warning on line 669 in gateway/gateway_test.go
probelabs / Visor: quality
architecture Issue
The sub-tests in `TestDistributedRateLimiterDisabledRedisEvents` modify a shared `globalConf` variable across test cases. This pattern is fragile and prevents tests from being run in parallel safely. Each sub-test should manage its own state and ensure proper cleanup to maintain test isolation.
Raw output
Refactor the sub-tests to be self-contained. Either create a fresh configuration object within each `t.Run` block or use `t.Cleanup` to guarantee that the configuration is restored, making the test more robust and safe for parallel execution.
Loading