Skip to content

Replace GitHub Action runners with WarpBuild runners#7597

Merged
bsten-tyk merged 2 commits intomasterfrom
releng/master
Dec 5, 2025
Merged

Replace GitHub Action runners with WarpBuild runners#7597
bsten-tyk merged 2 commits intomasterfrom
releng/master

Conversation

@bsten-tyk
Copy link
Copy Markdown
Contributor

This commit syncs latest changes from gromit, introduced via TykTechnologies/gromit#428, which introduces new WarpBuild runners to replace the Github's own runners.

Description

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates go.mod in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@bsten-tyk bsten-tyk requested a review from a team as a code owner December 5, 2025 08:32
@bsten-tyk bsten-tyk requested review from jeffy-mathew and removed request for a team December 5, 2025 08:32
@bsten-tyk bsten-tyk enabled auto-merge (squash) December 5, 2025 08:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2025

API Changes

no api changes detected

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Dec 5, 2025

This pull request migrates the CI runners for the .github/workflows/release.yml workflow from GitHub-hosted runners to WarpBuild runners. This change aims to standardize the CI infrastructure by updating the runs-on directive to use a centralized variable (${{ vars.DEFAULT_RUNNER }}) and switching the caching mechanism to a WarpBuild-specific action (WarpBuilds/cache@v1).

Files Changed Analysis

  • File Modified: .github/workflows/release.yml
  • Changes: 23 additions & 23 deletions.
  • Summary: The changes reflect a consistent pattern of replacement across all jobs within the workflow file. Hardcoded runner names have been replaced with a variable, and the caching action has been updated.

Architecture & Impact Assessment

  • What this PR accomplishes: It transitions the CI infrastructure for the release pipeline to use WarpBuild runners, moving away from GitHub's default runners to likely improve performance, cost, and maintainability.
  • Key technical changes introduced:
    1. Runner Standardization: All jobs now use ${{ vars.DEFAULT_RUNNER }}, which centralizes the runner configuration and simplifies future updates.
    2. Caching Mechanism Update: The cache action is now WarpBuilds/cache@v1, which is optimized for the WarpBuild environment.
  • Affected system components: This change exclusively affects the CI/CD pipeline defined in release.yml. It has no direct impact on the application's source code ```mermaid
    graph TD
    subgraph

Powered by Visor from Probelabs

Last updated: 2025-12-05T13:51:53.202Z | Triggered by: pr_updated | Commit: 43079c8

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Dec 5, 2025

Security Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/release.yml:96
The workflow uses a third-party GitHub Action (`WarpBuilds/cache@v1`) referenced by a mutable tag (`v1`). If an attacker compromises the action's repository and updates the `v1` tag to point to a malicious commit, the workflow could execute arbitrary code. This could lead to credential theft, code injection, or other supply chain attacks within the CI/CD pipeline. The same issue exists on line 530.
💡 SuggestionPin the action to a specific, immutable commit SHA instead of a tag. Replace `uses: WarpBuilds/cache@v1` with `uses: WarpBuilds/cache@<full-commit-hash>` after verifying the commit hash for the desired version in the source repository. This ensures the workflow always executes a specific, vetted version of the action.

Architecture Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/release.yml:289
The `resolve-dashboard-image` job uses a hardcoded runner (`warp-ubuntu-latest-x64-8x`) while other jobs in the same workflow have been updated to use the `${{ vars.DEFAULT_RUNNER }}` variable. This inconsistency undermines the benefit of centralizing the runner configuration and creates a future maintenance risk, as this job might be missed during subsequent runner updates.
💡 SuggestionTo ensure consistency and simplify maintenance, replace the hardcoded runner value with the repository variable `${{ vars.DEFAULT_RUNNER }}`.

✅ Performance Check Passed

No performance issues found – changes LGTM.

Quality Issues (1)

Severity Location Issue
🟡 Warning .github/workflows/release.yml:290
The `resolve-dashboard-image` job uses a hardcoded runner `warp-ubuntu-latest-x64-8x`, while other jobs in the workflow have been updated to use the `${{ vars.DEFAULT_RUNNER }}` variable. This inconsistency can lead to maintenance challenges, as this specific runner might be missed during future updates to the runner infrastructure.
💡 SuggestionTo improve consistency and maintainability, replace the hardcoded value with a variable. If this job requires a different runner from the default, consider introducing a new, descriptively named variable (e.g., `${{ vars.LARGE_RUNNER }}`) to make the configuration clearer and easier to manage.

Powered by Visor from Probelabs

Last updated: 2025-12-05T13:51:55.963Z | Triggered by: pr_updated | Commit: 43079c8

💡 TIP: You can chat with Visor using /visor ask <your question>

Comment thread .github/workflows/release.yml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 5, 2025

🚨 Jira Linter Failed

Commit: 43079c8
Failed at: 2025-12-05 13:50:05 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate branch and PR title rules: branch name 'releng/master' must contain a valid Jira ticket ID (e.g., ABC-123)

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

Comment thread .github/workflows/release.yml
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bsten-tyk bsten-tyk merged commit 1e5540c into master Dec 5, 2025
103 of 117 checks passed
@bsten-tyk bsten-tyk deleted the releng/master branch December 5, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants