Skip to content

Merge branch 'master' into TT-12238-javascript-regex-issue-on-oas-api…

be3b306
Select commit
Loading
Failed to load commit list.
Merged

[TT-12238] Javascript regex issue on OAS API #7923

Merge branch 'master' into TT-12238-javascript-regex-issue-on-oas-api…
be3b306
Select commit
Loading
Failed to load commit list.
probelabs / Visor: quality succeeded Apr 16, 2026 in 53s

✅ Check Passed (Warnings Found)

quality check passed. Found 2 warnings, but fail_if condition was not met.

Details

📊 Summary

  • Total Issues: 2
  • Warning Issues: 2

🔍 Failure Condition Results

Passed Conditions

  • global_fail_if: Condition passed

Issues by Category

Architecture (2)

  • ⚠️ gateway/api.go:1281 - The error returned by apiOAS.Clone() is ignored using // nolint:errcheck. While this function may currently never return an error, this assumption is fragile and can lead to silent failures if the underlying implementation changes. An unhandled error during a clone operation could lead to data corruption or inconsistent state.
  • ⚠️ gateway/api.go:1461 - The error returned by oasObj.Clone() is ignored using // nolint:errcheck. While this function may currently never return an error, this assumption is fragile and can lead to silent failures if the underlying implementation changes. An unhandled error during a clone operation could lead to inconsistent data being written to the filesystem.

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check warning on line 1281 in gateway/api.go

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

architecture Issue

The error returned by `apiOAS.Clone()` is ignored using `// nolint:errcheck`. While this function may currently never return an error, this assumption is fragile and can lead to silent failures if the underlying implementation changes. An unhandled error during a clone operation could lead to data corruption or inconsistent state.
Raw output
Handle the error explicitly. If an error here is considered an unrecoverable state (which it likely is), the program should panic or log a fatal error to ensure the failure is immediately visible and stops further execution with a potentially nil or invalid object.

Check warning on line 1461 in gateway/api.go

See this annotation in the file changed.

@probelabs probelabs / Visor: quality

architecture Issue

The error returned by `oasObj.Clone()` is ignored using `// nolint:errcheck`. While this function may currently never return an error, this assumption is fragile and can lead to silent failures if the underlying implementation changes. An unhandled error during a clone operation could lead to inconsistent data being written to the filesystem.
Raw output
Handle the error explicitly. If an error here is considered an unrecoverable state, the program should panic or log a fatal error to ensure the failure is immediately visible and stops further execution before writing a potentially invalid object to a file.