Skip to content

[TT-16977] fix: goreleaser skipped on push/tag when dep-guard is skipped #8007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 1 commit into from
Apr 15, 2026

fix: goreleaser skipped on push/tag when dep-guard is skipped

7f7793b
Select commit
Loading
Failed to load commit list.
Merged

[TT-16977] fix: goreleaser skipped on push/tag when dep-guard is skipped #8007

fix: goreleaser skipped on push/tag when dep-guard is skipped
7f7793b
Select commit
Loading
Failed to load commit list.
probelabs / Visor: architecture failed Apr 15, 2026 in 40s

🚨 Check Failed

architecture check failed because fail_if condition was met.

Details

📊 Summary

  • Total Issues: 2
  • Error Issues: 2

🔍 Failure Condition Results

Failed Conditions

  • global_fail_if: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')
    • Severity: ❌ error

Issues by Category

Logic (2)

  • ❌ .github/workflows/release.yml:42 - The if condition is logically flawed and will not fix the issue for non-pull-request events like pushes or tags. The expression github.event.pull_request.draft == false will evaluate to false when the event is not a pull request, as github.event.pull_request will be null. This will cause the entire condition to be false, and the goreleaser job will continue to be skipped on release-triggering events, which is the bug this change intends to fix.
  • ❌ system:0 - Global failure condition met: output.issues && output.issues.some(i => i.severity === 'critical' || i.severity === 'error')

Powered by Visor from Probelabs

💡 TIP: You can chat with Visor using /visor ask <your question>

Annotations

Check failure on line 45 in .github/workflows/release.yml

See this annotation in the file changed.

@probelabs probelabs / Visor: architecture

logic Issue 

The `if` condition is logically flawed and will not fix the issue for non-pull-request events like pushes or tags. The expression `github.event.pull_request.draft == false` will evaluate to `false` when the event is not a pull request, as `github.event.pull_request` will be `null`. This will cause the entire condition to be false, and the `goreleaser` job will continue to be skipped on release-triggering events, which is the bug this change intends to fix.
Raw output 
The condition should be modified to explicitly handle cases where the event is not a pull request. It should allow the job to run for non-PR events, or for PRs that are not drafts.
View more details on probelabs