[TT-16951] fix: plugin compiler FIPS support + goplugin tag #8012
+44
−12
probelabs / Visor: quality
succeeded
Apr 15, 2026 in 1m 6s
✅ Check Passed (Warnings Found)
quality check passed. Found 1 warning, but fail_if condition was not met.
Details
📊 Summary
- Total Issues: 1
- Warning Issues: 1
🔍 Failure Condition Results
Passed Conditions
- global_fail_if: Condition passed
Issues by Category
Architecture (1)
⚠️ .github/workflows/plugin-compiler-build.yml:115 - The new FIPS build job is almost a complete copy of the existing build jobs for other variants. This introduces significant code duplication in the CI pipeline, making it harder to maintain and more prone to errors. Future changes to the build process will need to be replicated across all jobs.
Powered by Visor from Probelabs
💡 TIP: You can chat with Visor using /visor ask <your question>
Annotations
Check warning on line 147 in .github/workflows/plugin-compiler-build.yml
probelabs / Visor: quality
architecture Issue
The new FIPS build job is almost a complete copy of the existing build jobs for other variants. This introduces significant code duplication in the CI pipeline, making it harder to maintain and more prone to errors. Future changes to the build process will need to be replicated across all jobs.
Raw output
To improve maintainability, refactor the workflow to use a matrix strategy. This would allow you to define the different build variants (e.g., standard, EE, FIPS) as matrix parameters and use a single, templatized job definition to handle all builds. This approach centralizes the build logic, eliminates duplication, and makes the workflow easier to manage.
Loading