Skip to content

[TT-16342] fix: align plugin compiler Go version with gateway (1.25) #8039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 1 commit into from
Apr 16, 2026
Merged

[TT-16342] fix: align plugin compiler Go version with gateway (1.25) #8039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/plugin-compiler-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
- "v*"

env:
GOLANG_CROSS: 1.24-bullseye
GOLANG_CROSS: 1.25-bullseye

Check warning on line 20 in .github/workflows/plugin-compiler-build.yml

View check run for this annotation

probelabs / Visor: architecture

architecture Issue 

The `golang-cross` version `1.25-bullseye` is hardcoded. This version string is now present in at least two locations: this workflow file and `ci/images/plugin-compiler/Dockerfile`. The PR description also mentions a 'gateway goreleaser', which might be a third location. Hardcoding the same version string in multiple places creates a risk of them drifting apart in the future, leading to the same kind of plugin incompatibility issue this PR aims to fix. To improve maintainability, consider centralizing this version string.
Raw output 
Define the `golang-cross` version in a single source of truth, for example, a dedicated version file in the repository root (e.g., `.golang-cross-version`). All build scripts (GitHub Actions, Dockerfile builds, goreleaser) should then read from this file. This ensures all components are always built with a consistent environment.

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion ci/images/plugin-compiler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG BASE_IMAGE=tykio/golang-cross:1.24-bullseye
ARG BASE_IMAGE=tykio/golang-cross:1.25-bullseye
FROM ${BASE_IMAGE}

LABEL description="Image for plugin development"
Expand Down
Loading