Skip to content

[TT-16342] revert: undo incorrect OTel scenario update (PR #8041)#8047

Merged
buger merged 1 commit intorelease-5.12from
revert/otel-scenarios-5.12
Apr 16, 2026
Merged

[TT-16342] revert: undo incorrect OTel scenario update (PR #8041)#8047
buger merged 1 commit intorelease-5.12from
revert/otel-scenarios-5.12

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 16, 2026

Summary

Reverts PR #8041 which incorrectly updated OTel test scenarios to use NEW attribute names on release-5.12.

release-5.12 uses otelhttp v0.49.0 (pinned via go.mod replace), which emits OLD names:

  • http.method (not http.request.method)
  • http.status_code (not http.response.status_code)
  • http.user_agent (not user_agent.original)
  • http.wrote_bytes (not http.response.body.size)

The scenario update was only correct for master (otelhttp v0.65.0).

🤖 Generated with Claude Code

Reverts the OTel test scenario changes from PR #8041. The release-5.12
branch uses otelhttp v0.49.0 which emits OLD semantic convention
attribute names (http.method, http.status_code, etc.). The scenarios
were incorrectly updated to expect NEW names (http.request.method,
http.response.status_code, etc.) which the gateway does not emit.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 16, 2026 15:55
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: e5bc04f
Failed at: 2026-04-16 15:56:21 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate branch and PR title rules: branch name 'revert/otel-scenarios-5.12' must contain a valid Jira ticket ID (e.g., ABC-123)

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

This pull request reverts PR #8041, which incorrectly updated OpenTelemetry (OTel) test scenarios with attribute names that are not compatible with the release-5.12 branch.

The release-5.12 branch uses an older version of the otelhttp library (v0.49.0), which emits older OTel attribute names. The original PR introduced newer attribute names (e.g., http.request.method) that are only correct for the master branch, causing tests to fail on the release branch. This PR reverts those changes to align the tests with the library version in use.

Files Changed Analysis

  • 16 files changed, all of which are YAML test scenario definitions located in ci/tests/tracing/scenarios/.
  • The changes are uniform across all files, consisting of reverting OpenTelemetry attribute names in test selectors and assertions.
  • There are 58 additions and 58 deletions, reflecting the direct replacement of incorrect attribute names with the correct ones.

Architecture & Impact Assessment

  • What this PR accomplishes: It fixes the broken OpenTelemetry integration tests on the release-5.12 branch by restoring the expected OTel attribute names to their older format, ensuring test assertions match the actual data emitted by the gateway.

  • Key technical changes introduced: The changes are exclusively within test configuration files. Newer OTel attribute names are reverted to their older counterparts. Examples include:

    • http.request.method -> http.method
    • http.response.status_code -> http.status_code
    • user_agent.original -> http.user_agent
    • http.response.body.size -> http.wrote_bytes
    • url.full -> http.url
  • Affected system components: The impact is confined to the CI/CD pipeline and the tracing test suite. There are no changes to the application's runtime code or its architecture. The sole purpose is to correct test assertions.

Scope Discovery & Context Expansion

  • The scope of this PR is strictly limited to the test scenarios for OpenTelemetry tracing. It does not affect any application logic, dependencies, or user-facing functionality.
  • This change highlights a dependency divergence between the master and release-5.12 branches, specifically concerning the otelhttp library and its corresponding OTel semantic conventions. It serves as a reminder that backporting changes from master requires careful verification against the dependency set of the target release branch.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: bug

Powered by Visor from Probelabs

Last updated: 2026-04-16T15:57:38.898Z | Triggered by: pr_opened | Commit: e5bc04f

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Security Check Passed

No security issues found – changes LGTM.

\n\n \n\n

✅ Performance Check Passed

No performance issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-04-16T15:57:16.721Z | Triggered by: pr_opened | Commit: e5bc04f

💡 TIP: You can chat with Visor using /visor ask <your question>

@buger buger merged commit ccd83df into release-5.12 Apr 16, 2026
16 of 19 checks passed
@buger buger deleted the revert/otel-scenarios-5.12 branch April 16, 2026 15:58
@buger
Copy link
Copy Markdown
Member Author

buger commented Apr 16, 2026

Closing: Go 1.25 updated the OTel HTTP instrumentation library on release-5.12.1, so scenarios need the NEW-style attribute names (e.g. http.request.method instead of http.method). This revert was incorrect. Correct fix applied in PR #8059.

@buger buger changed the title revert: undo incorrect OTel scenario update (PR #8041) [TT-16342] revert: undo incorrect OTel scenario update (PR #8041) Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant