Skip to content

[TT-16342] revert: undo incorrect OTel scenario update (PR #8042)#8048

Merged
buger merged 1 commit intorelease-5.12.1from
revert/otel-scenarios-5.12.1
Apr 16, 2026
Merged

[TT-16342] revert: undo incorrect OTel scenario update (PR #8042)#8048
buger merged 1 commit intorelease-5.12.1from
revert/otel-scenarios-5.12.1

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 16, 2026

Summary

Reverts PR #8042 which incorrectly updated OTel test scenarios to use NEW attribute names on release-5.12.1.

release-5.12.1 uses otelhttp v0.60.0 which defaults to OLD attribute names unless OTEL_SEMCONV_STABILITY_OPT_IN is set.

🤖 Generated with Claude Code

Reverts the OTel test scenario changes from PR #8042. The release-5.12.1
branch uses otelhttp v0.60.0 which defaults to OLD semantic convention
attribute names. The scenarios were incorrectly updated to expect NEW names.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 16, 2026 15:55
@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

\n\n \n\n \n\n

Powered by Visor from Probelabs

Last updated: 2026-04-16T15:56:05.020Z | Triggered by: pr_opened | Commit: bdebe8d

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026


Powered by Visor from Probelabs

Last updated: 2026-04-16T15:56:05.801Z | Triggered by: pr_opened | Commit: bdebe8d

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@buger buger merged commit 1d4a50a into release-5.12.1 Apr 16, 2026
8 of 10 checks passed
@buger buger deleted the revert/otel-scenarios-5.12.1 branch April 16, 2026 15:58
@buger
Copy link
Copy Markdown
Member Author

buger commented Apr 16, 2026

Closing: Go 1.25 updated the OTel HTTP instrumentation library on release-5.12.1, so scenarios need the NEW-style attribute names (e.g. http.request.method instead of http.method). This revert was incorrect. Correct fix applied in PR #8059.

@buger buger changed the title revert: undo incorrect OTel scenario update (PR #8042) [TT-16342] revert: undo incorrect OTel scenario update (PR #8042) Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: bdebe8d
Failed at: 2026-04-21 10:12:02 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to get Jira issue: failed to fetch Jira issue TT-16342: Issue does not exist or you do not have permission to see it.: request failed. Please analyze the request body for more details. Status code: 404

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant