Skip to content

fix: backport tslib dependency for portman contract tests#8058

Closed
buger wants to merge 1 commit intorelease-5.12.1from
fix/tslib-backport-5.12.1
Closed

fix: backport tslib dependency for portman contract tests#8058
buger wants to merge 1 commit intorelease-5.12.1from
fix/tslib-backport-5.12.1

Conversation

@buger
Copy link
Copy Markdown
Member

@buger buger commented Apr 16, 2026

Summary

Test plan

  • Verify portman contract tests pass in CI on the release-5.12.1 branch

🤖 Generated with Claude Code

Backport of #7995 — @apideck/portman requires tslib at runtime but
doesn't declare it as a direct dependency.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@buger buger requested a review from a team as a code owner April 16, 2026 20:41
@github-actions
Copy link
Copy Markdown
Contributor

🚨 Jira Linter Failed

Commit: bd05a47
Failed at: 2026-04-16 20:41:52 UTC

The Jira linter failed to validate your PR. Please check the error details below:

🔍 Click to view error details
failed to validate branch and PR title rules: neither branch name 'fix/tslib-backport-5.12.1' nor PR title 'fix: backport tslib dependency for portman contract tests' contains a valid Jira ticket ID (e.g., ABC-123)

Next Steps

  • Ensure your branch name contains a valid Jira ticket ID (e.g., ABC-123)
  • Verify your PR title matches the branch's Jira ticket ID
  • Check that the Jira ticket exists and is accessible

This comment will be automatically deleted once the linter passes.

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

This PR is a backport that resolves a runtime failure in the Portman contract tests. The @apideck/portman package has an undeclared dependency on tslib, causing tests to fail. This fix explicitly adds tslib to the dependencies in ci/tests/specs/package.json to ensure the testing environment is correctly configured.

Files Changed Analysis

  • ci/tests/specs/package.json: A single line was added to include "tslib": "^2.6.2" in the dependencies object. This is a standard dependency addition.

Architecture & Impact Assessment

  • What this PR accomplishes: It fixes the failing Portman contract tests on the release-5.12.1 branch by providing a missing, required dependency.
  • Key technical changes introduced: The tslib library is added as a direct dependency for the CI test suite.
  • Affected system components: The impact is isolated to the CI/CD pipeline's contract testing stage. There are no changes to the application's source code, architecture, or its own dependencies.

Scope Discovery & Context Expansion

  • The change is highly localized to the Node.js environment used for running contract tests, defined in ci/tests/specs/. The fix addresses a dependency management issue within a development tool, not the main application. This is a targeted maintenance operation to ensure the stability of the CI process for a release branch.
Metadata
  • Review Effort: 1 / 5
  • Primary Label: bug

Powered by Visor from Probelabs

Last updated: 2026-04-16T20:42:41.078Z | Triggered by: pr_opened | Commit: bd05a47

💡 TIP: You can chat with Visor using /visor ask <your question>

@probelabs
Copy link
Copy Markdown
Contributor

probelabs Bot commented Apr 16, 2026

✅ Security Check Passed

No security issues found – changes LGTM.

✅ Architecture Check Passed

No architecture issues found – changes LGTM.

✅ Performance Check Passed

No performance issues found – changes LGTM.


Powered by Visor from Probelabs

Last updated: 2026-04-16T20:42:16.714Z | Triggered by: pr_opened | Commit: bd05a47

💡 TIP: You can chat with Visor using /visor ask <your question>

@github-actions
Copy link
Copy Markdown
Contributor

API Changes

no api changes detected

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@buger
Copy link
Copy Markdown
Member Author

buger commented Apr 17, 2026

Closing in favor of full backport of #7995

@buger buger closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant