Skip to content

[TT-16966][TT-16971] fix: backport #7995 — fix tslib and npm ci in ci/tests/specs #8065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buger merged 1 commit into from
Apr 17, 2026
+3,257 −3
Merged

[TT-16966][TT-16971] fix: backport #7995 — fix tslib and npm ci in ci/tests/specs #8065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ main
/coprocess/*.pb.go-e
ci/tests/specs/tmp
ci/tests/specs/node_modules
ci/tests/specs/package-lock.json
ci/tests/specs/gateway.collection.postman.json
ci/tests/specs/.env
ci/tests/specs/apps
Expand Down
2 changes: 1 addition & 1 deletion ci/tests/specs/Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
tests:
desc: "Run the OpenAPI specification tests"
cmds:
- venom run testdata/populate_gateway_test_data.yaml --var bearerToken=$PORTMAN_API_Key --stop-on-failure && rm venom*.log

Check warning on line 15 in ci/tests/specs/Taskfile.yml

View check run for this annotation

probelabs / Visor: security

security Issue 

The `npm ci` command executes lifecycle scripts from dependencies by default. The previous command, `npm install --ignore-scripts`, explicitly disabled this, which is a security best practice to mitigate supply-chain attacks. Re-enabling scripts by default introduces a potential risk, as a compromised dependency could execute malicious code during the CI build process.
Raw output 
To maintain the previous security posture and adhere to the principle of least privilege, add the `--ignore-scripts` flag to the `npm ci` command. This should only be omitted if a dependency is known to require scripts for installation.
- npm install --ignore-scripts
- npm ci
- npm start

build:
Expand Down
Loading
Loading